drop a TODOne

elastic · Dec 11, 2024 · 71f9b27 · 71f9b27
1 parent 241f778
commit 71f9b27
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/test-instrumentation-openai.yml b/.github/workflows/test-instrumentation-openai.yml
@@ -87,7 +87,8 @@ jobs:
       working-directory: packages/instrumentation-openai
     - run: npm run compile
       working-directory: packages/instrumentation-openai
-    - run: |
+    - name: Integration tests
+      run: |
         set -a; source ./ollama.env
         npm run test:integration
       working-directory: packages/instrumentation-openai
diff --git a/packages/instrumentation-openai/test/fixtures.test.js b/packages/instrumentation-openai/test/fixtures.test.js
@@ -1312,7 +1312,6 @@ test('fixtures', async suite => {
       },
     },
 
-    // TODO: tests with captureMessageContent=false
     // TODO: see Python's test_all_the_client_options, do something similar
     // TODO: test with a tool response from user after a tool call (to test https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-events.md#tool-event)
     // TODO: test a case where stream fails before completion: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-events.md#choice-event says SHOULD have an event with truncated content and finish_reason=error