chore: bump min supported Node.js to v14.18.0 (#280)

The transitive [email protected] dep breaks on Node.js versions before v14.18.0. (Actually uuid@10 is being used, which technically no longer supports Node.js v14, but still works with later minors.) Also: * fix the conditional for installing an npm that supports workspaces * while we are changing Node versions we test with, the IITM fix came a while back, so we can test with latest v18 now Refs: googleapis/gaxios#637
elastic · Aug 1, 2024 · ba8e638 · ba8e638
1 parent 378aadf
commit ba8e638
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -37,7 +37,7 @@ jobs:
           - '22.0'
           - '20'
           - '20.0'
-          - '18.18.2' # Skip >=18.19.0 until IITM issues are resolved.
+          - '18'
           - '18.0'
           - '16'
           - '16.0'

diff --git a/packages/opentelemetry-node/CHANGELOG.md b/packages/opentelemetry-node/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Bump minimum supported Node.js version to v14.18.0.
+  (Previously it was v14.17.0.)
+
 - feat: Add the following instrumentations:
     ```
     @opentelemetry/instrumentation-connect
@@ -15,12 +18,12 @@
     @opentelemetry/instrumentation-memcached
     @opentelemetry/instrumentation-nestjs-core
     @opentelemetry/instrumentation-net
+    @opentelemetry/instrumentation-redis
     @opentelemetry/instrumentation-restify
     @opentelemetry/instrumentation-router
     @opentelemetry/instrumentation-socket.io
     ```
 
-
 ## v0.2.0
 
 - feat: Add the following `@opentelemetry/instrumentation-*` instrumentations:

diff --git a/packages/opentelemetry-node/docs/supported-technologies.mdx b/packages/opentelemetry-node/docs/supported-technologies.mdx
@@ -15,9 +15,15 @@ Elastic stack, so it is strongly recommended to be using a recent 8.x version.
 
 ## Node.js versions
 
-The Elastic Distribution for OpenTelemety Node.js supports Node.js v14 and later.
+The Elastic Distribution for OpenTelemety Node.js supports Node.js v14.18.0 and later.
 This follows from the [OpenTelemetry JS supported runtimes](https://github.com/open-telemetry/opentelemetry-js#supported-runtimes).
 
+<!--
+Dev Notes on supported Node.js versions:
+- v14.18.0 or later is required for `node:`-prefixed core module loading, as
+  used by [email protected], a transitive dep of `@opentelemetry/resource-detector-gcp`.
+-->
+
 
 ## Instrumentations
 

diff --git a/packages/opentelemetry-node/package.json b/packages/opentelemetry-node/package.json
@@ -24,7 +24,7 @@
   ],
   "author": "Elastic Observability <https://www.elastic.co/observability>",
   "engines": {
-    "node": ">=14"
+    "node": ">=14.18.0"
   },
   "files": [
     "lib",
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,7 +37,7 @@ jobs: @@
               - '22.0'
               - '20'
               - '20.0'
-              - '18.18.2' # Skip >=18.19.0 until IITM issues are resolved.
+              - '18'
               - '18.0'
               - '16'
               - '16.0'
@@ Expand Down @@