Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mockotlpserver): fix an alignment issue in trace-summary gutter with 1-char units #574

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix(mockotlpserver): fix an alignment issue in trace-summary gutter with 1-char units #574

merged 1 commit into from
Jan 30, 2025

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 29, 2025

Before:

------ trace 43670f (3 spans) ------
       span 7dc366 "Test Parent" (2007.4ms, SPAN_KIND_INTERNAL)
  +1ms `- span f84ec1 "Test Child 1" (1003.2ms, SPAN_KIND_INTERNAL)
  +1s `- span 534247 "Test Child 2" (1002.1ms, SPAN_KIND_INTERNAL)

After:

------ trace 43670f (3 spans) ------
       span 7dc366 "Test Parent" (2007.4ms, SPAN_KIND_INTERNAL)
  +1ms `- span f84ec1 "Test Child 1" (1003.2ms, SPAN_KIND_INTERNAL)
  +1s  `- span 534247 "Test Child 2" (1002.1ms, SPAN_KIND_INTERNAL)

@trentm
fix(mockotlpserver): fix an alignment issue in trace-summary gutter w…
53f16ac 
…ith 1-char units

Before:

```
------ trace 43670f (3 spans) ------
       span 7dc366 "Test Parent" (2007.4ms, SPAN_KIND_INTERNAL)
  +1ms `- span f84ec1 "Test Child 1" (1003.2ms, SPAN_KIND_INTERNAL)
  +1s `- span 534247 "Test Child 2" (1002.1ms, SPAN_KIND_INTERNAL)
```

After:

```
------ trace 43670f (3 spans) ------
       span 7dc366 "Test Parent" (2007.4ms, SPAN_KIND_INTERNAL)
  +1ms `- span f84ec1 "Test Child 1" (1003.2ms, SPAN_KIND_INTERNAL)
  +1s  `- span 534247 "Test Child 2" (1002.1ms, SPAN_KIND_INTERNAL)
```
@trentm trentm requested a review from david-luna January 29, 2025 20:13
@trentm trentm self-assigned this Jan 29, 2025
@trentm trentm merged commit b36cf66 into main Jan 30, 2025
4 checks passed
@trentm trentm deleted the trentm/mockotlpserver-gutter-align branch January 30, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-luna david-luna david-luna approved these changes

Assignees

@trentm trentm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trentm @david-luna