Add Using CrewAI with Elasticsearch notebook #415
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/415 |
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
...-blog-content/using-crewai-with-elasticsearch/using_crewai_with_elasticsearch_notebook.ipynb
Outdated
Show resolved
Hide resolved
...-blog-content/using-crewai-with-elasticsearch/using_crewai_with_elasticsearch_notebook.ipynb
Outdated
Show resolved
Hide resolved
...-blog-content/using-crewai-with-elasticsearch/using_crewai_with_elasticsearch_notebook.ipynb
Outdated
Show resolved
Hide resolved
| " yield {\"_index\": \"summer-clothes\", \"_source\": doc}\n", | ||
| "\n", | ||
| "\n", | ||
| "try:\n", |
There was a problem hiding this comment.
This times out when the inference endpoint is being built. Might want to add a note to wait up to 10 seconds between executing this next step to give clothes_inference a chance to start?
|
@Delacrobix when you get a chance can you sign the Contributor Agreement |
|
@Delacrobix just a couple suggested edits to the notebook |
…crewai_with_elasticsearch_notebook.ipynb Co-authored-by: Justin Castilla <[email protected]>
…crewai_with_elasticsearch_notebook.ipynb Co-authored-by: Justin Castilla <[email protected]>
…crewai_with_elasticsearch_notebook.ipynb Co-authored-by: Justin Castilla <[email protected]>
|
Hi @justincastilla, thank you so much for your feedback. All changes have been committed, and I have signed the Contributor Agreement. |
|
Hi, @Delacrobix - You might want to confirm that your GitHub email matches the email you used to sign the CLA. I also have a follow-up question: when signing the contributor agreement, did you say you were an Elastic employee? |
Hi, @JessicaGarson I signed up as an individual contributor. I used the same email as my GitHub account, but it doesn't seem to be working yet. |
|
Thanks, @Delacrobix. I chatted with a coworker about this issue, and he mentioned that this happens when the person signs the CLA with one email address and then uses a different one in the PR. The email address must be the same. Is this possible here? |
|
I signed with my GitHub email account, but it didn’t work. :/ Proof image: I don’t know what else to try. Thank you so much for your help @JessicaGarson |
|
Some of those commits were made with [email protected], see https://github.com/elastic/elasticsearch-labs/commit/b915ed328322465249267fad6fb8feeb6f217373.patch Can we squash / rebase those commits to all use the email you signed the CLA with? That should help :) |
|
I think I figured out how to change the author of the commit and made a new PR: #439 |
|
@xeraa Thank you so much for your help, it worked! @JessicaGarson I opened a new pull request: #440 I'll do the same for the others PRs I created. I will close this PR. |
|
@Delacrobix - it looks like we both did the same thing. I'm happy to use yours or mine. |
|
@JessicaGarson Ah! Sorryyy I didn’t fully understand your comment. Let’s go with your version! |
|
Thanks, @Delacrobix. I'll close this thread PR once it gets approved and merged. |
No description provided.