-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supporting blog content on the why and how for BBQ #431
base: main
Are you sure you want to change the base?
Conversation
Can you add a readme to the folder to explain which file is which and that it corresponds to the specific search labs piece? If someone finds this content first they may wonder what is going on. |
Thanks, @carlyrichmond! I added a README and made some changes to the structure that I thought might make the code easier to work with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new structure looks better. I reworded one thing in the readme. I don't think this should be merged and made public until after the 8.18 release docs are public. Obviously this would be alongside the article too.
Co-authored-by: Carly Richmond <[email protected]>
Thanks, @carlyrichmond. I committed to that suggestion. I agree on waiting on the merging; my thought was after 8.18 is public but shortly before the article is live. |
@@ -40,9 +40,6 @@ GET my-raw-vector-index/_search | |||
"model_text": "my awesome search field" | |||
} | |||
}, | |||
"rescore_vector": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this taken out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was because we had it twice. The field is now in 06-bbq-search-8-18.json
as:
"rescore_vector": {
"oversample": 3
}
Code for this blog post #1431