Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supporting blog content on the why and how for BBQ #431

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JessicaGarson
Copy link
Contributor

@JessicaGarson JessicaGarson commented Mar 21, 2025

@JessicaGarson JessicaGarson marked this pull request as ready for review March 27, 2025 18:46
@carlyrichmond
Copy link
Contributor

Can you add a readme to the folder to explain which file is which and that it corresponds to the specific search labs piece? If someone finds this content first they may wonder what is going on.

@JessicaGarson
Copy link
Contributor Author

Thanks, @carlyrichmond! I added a README and made some changes to the structure that I thought might make the code easier to work with.

Copy link
Contributor

@carlyrichmond carlyrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new structure looks better. I reworded one thing in the readme. I don't think this should be merged and made public until after the 8.18 release docs are public. Obviously this would be alongside the article too.

@JessicaGarson
Copy link
Contributor Author

JessicaGarson commented Apr 2, 2025

Thanks, @carlyrichmond. I committed to that suggestion. I agree on waiting on the merging; my thought was after 8.18 is public but shortly before the article is live.

@@ -40,9 +40,6 @@ GET my-raw-vector-index/_search
"model_text": "my awesome search field"
}
},
"rescore_vector": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this taken out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was because we had it twice. The field is now in 06-bbq-search-8-18.json as:

"rescore_vector": {
              "oversample": 3
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants