make str log fields consistent #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for getting a start on this! |
juliaElastic
commented
Feb 1, 2024
| @@ -431,7 +431,7 @@ func runCoordinatorOutput(ctx context.Context, cord Coordinator, bulker bulk.Bul | |||
| if err != nil { | |||
| s.Err(err).Msg("Policy coordinator failed to add a new policy revision") | |||
| } else { | |||
| s.Info().Int64("revision_id", p.RevisionIdx).Msg("Policy coordinator added a new policy revision") | |||
There was a problem hiding this comment.
removed redundant log field (already there in line 429)
internal/pkg/api/handleCheckin.go
Outdated
| @@ -765,8 +766,8 @@ func processPolicy(ctx context.Context, zlog zerolog.Logger, bulker bulk.Bulk, a | |||
| defer span.End() | |||
| zlog = zlog.With(). | |||
| Str("fleet.ctx", "processPolicy"). | |||
| Int64("fleet.policyRevision", pp.Policy.RevisionIdx). | |||
| Int64("fleet.policyCoordinator", pp.Policy.CoordinatorIdx). | |||
| Int64(dl.FieldRevisionIdx, pp.Policy.RevisionIdx). | |||
There was a problem hiding this comment.
Should we define these as constants in logger/ecs.go?
michel-laterman
approved these changes
Feb 8, 2024
|
59.5% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.
Making log fields consistent to make it easier to check the logs.
How does this PR solve the problem?
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.
How to test this PR locally
Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolRelated issues
Closes #3239