Audit unenroll should not set unenrolled_at attribute #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
bug
michalpristas
approved these changes
Dec 17, 2024
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Do not set the unenrolled_at attribute when the audit/unenroll API is called. Remove the unenrolled_at attribute if it's set during checkin. (cherry picked from commit 8450b71)
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Do not set the unenrolled_at attribute when the audit/unenroll API is called. Remove the unenrolled_at attribute if it's set during checkin. (cherry picked from commit 8450b71)
This was referenced Dec 17, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Do not set the unenrolled_at attribute when the audit/unenroll API is called. Remove the unenrolled_at attribute if it's set during checkin. (cherry picked from commit 8450b71)
3 tasks
michel-laterman
added a commit
that referenced
this pull request
Dec 17, 2024
Do not set the unenrolled_at attribute when the audit/unenroll API is called. Remove the unenrolled_at attribute if it's set during checkin. (cherry picked from commit 8450b71) Co-authored-by: Michel Laterman <[email protected]>
ycombinator
pushed a commit
that referenced
this pull request
Dec 18, 2024
Do not set the unenrolled_at attribute when the audit/unenroll API is called. Remove the unenrolled_at attribute if it's set during checkin. (cherry picked from commit 8450b71) Co-authored-by: Michel Laterman <[email protected]>
michel-laterman
added a commit
that referenced
this pull request
Dec 19, 2024
Do not set the unenrolled_at attribute when the audit/unenroll API is called. Remove the unenrolled_at attribute if it's set during checkin. (cherry picked from commit 8450b71) Co-authored-by: Michel Laterman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
On systems where defend is running and may report as orphaned during an upgrade process, the
unenrolled_atattribute will be set and will prevent future upgrade commands from being issued through Kibana.How does this PR solve the problem?
Do not set the
unenrolled_atattribute when the audit/unenroll API is called.Remove the
unenrolled_atattribute if it's set during checkin.Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolRelated issues