Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk_indexer: Remove ES field mapper field preview #190

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jul 26, 2024

Removes the field mapper exception field preview returned in the error reason by Elasticsearch.

@kruskall kruskall requested a review from a team as a code owner July 26, 2024 12:18
@obltmachine obltmachine added the safe-to-test Automated label for running bench-diff on forked PRs label Jul 26, 2024
bulk_indexer.go Outdated Show resolved Hide resolved
1pkg
1pkg previously approved these changes Jul 26, 2024
simitt
simitt previously requested changes Jul 29, 2024
Copy link

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ on Carson's comment in #190 (comment)

Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still investigating the 2 different "types" / "reason" of error under x_content_parse_exception. Let's keep this PR open until we have a better idea of what's happening.

bulk_indexer.go Outdated Show resolved Hide resolved
@simitt simitt dismissed their stale review July 29, 2024 14:32

original comment revisited

Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kruskall kruskall merged commit 068fe43 into elastic:main Jul 29, 2024
5 checks passed
@kruskall kruskall deleted the replace/field-value-preview branch July 29, 2024 15:55
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Aug 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/elastic/go-docappender/v2](https://togithub.com/elastic/go-docappender)
| `v2.2.0` -> `v2.2.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.0/v2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.0/v2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>elastic/go-docappender
(github.com/elastic/go-docappender/v2)</summary>

###
[`v2.2.1`](https://togithub.com/elastic/go-docappender/releases/tag/v2.2.1)

[Compare
Source](https://togithub.com/elastic/go-docappender/compare/v2.2.0...v2.2.1)

##### What's Changed

- build(deps): bump the otel group with 5 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/elastic/go-docappender/pull/186](https://togithub.com/elastic/go-docappender/pull/186)
- ci: add integrationtest to dependabot by
[@&#8203;kruskall](https://togithub.com/kruskall) in
[https://github.com/elastic/go-docappender/pull/187](https://togithub.com/elastic/go-docappender/pull/187)
- build(deps): bump github.com/elastic/go-elasticsearch/v8 from 8.13.1
to 8.14.0 in /integrationtest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/elastic/go-docappender/pull/188](https://togithub.com/elastic/go-docappender/pull/188)
- bulk_indexer: Remove ES field mapper field preview by
[@&#8203;kruskall](https://togithub.com/kruskall) in
[https://github.com/elastic/go-docappender/pull/190](https://togithub.com/elastic/go-docappender/pull/190)

**Full Changelog**:
elastic/go-docappender@v2.2.0...v2.2.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Yang Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Automated label for running bench-diff on forked PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants