-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for secrets storage in agent outputs #696
Conversation
docs/en/ingest-management/fleet/fleet-settings-output-kafka.asciidoc
Outdated
Show resolved
Hide resolved
Thanks for the feedback @jillguyonnet. Sorry it took me so long to circle back to this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks!
I have a small suggestion (feel free to ignore): what do you think of adding a sentence like "Note that this setting can also be stored as secret value or plain text for preconfigured outputs" with a link to the Fleet settings page?
Also, will the secret storage of the service token for the remote Elasticsearch output type be documented separately? I had added it to the issue, but perhaps it would make more sense to include the part about secret storage in the dedicated doc issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ffac40a
@jillguyonnet Great suggestions! I added the note that you suggested to the three settings mentioned in this PR. I missed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for iterating, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Docs for secrets storage in agent outputs * secret storage through config file * Jill's feedback * remove changes from policies page * Add reference to preconfiguration settings docs * Add note to SSL key setting, Logstash & Kafka (cherry picked from commit f9e23bd)
* Docs for secrets storage in agent outputs * secret storage through config file * Jill's feedback * remove changes from policies page * Add reference to preconfiguration settings docs * Add note to SSL key setting, Logstash & Kafka (cherry picked from commit f9e23bd) Co-authored-by: David Kilfoyle <[email protected]>
This adds docs for agent output secrets.
@jillguyonnet This is definitely a "first draft". I'm not sure that I've got the "Policy secret values" section (down at the bottom) quite right. Please let me know what you think.
Target: 8.12
Rel: #692
Docs preview links:
Update to Logstash and Kafka outputs pages:
![Screenshot 2023-12-05 at 4 43 45 PM](https://private-user-images.githubusercontent.com/41695641/288212638-9bc472fe-15be-4727-90f6-50e5329a2558.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTAyODMsIm5iZiI6MTczOTE4OTk4MywicGF0aCI6Ii80MTY5NTY0MS8yODgyMTI2MzgtOWJjNDcyZmUtMTViZS00NzI3LTkwZjYtNTBlNTMyOWEyNTU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEyMTk0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkMGM4MTJkZjllMzBlM2ViODA5MzM4NWI1Y2M2MzRhMmUxZThkZTc5OWQzMjRjNWE4OTc0NDM4ZTJhYjdjNjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.m6LIiLSVXo34oLyT87lrIFZJg8Lt76XYNqNss0x8RSQ)