Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integrations] make ssl description in manifest.yml uniform with links to online documentation #12487

Closed
wants to merge 9 commits into from
Closed

[Integrations] make ssl description in manifest.yml uniform with links to online documentation #12487

wants to merge 9 commits into from
+1,349 −416

Conversation

StacieClark-Elastic
Copy link
Member

@StacieClark-Elastic StacieClark-Elastic commented Jan 27, 2025 •
edited
Loading

updated ssl entries in manifest.yml files to have uniform text and to point to online documentation for ssl options
The description field for ssl configurations across all integrations were not uniform. Some descriptions were missing

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

Each integration that has an updated manifest.yml must have an undated changelog.yml file.

How to test this PR locally

Manual inspection.

  • List all descriptions:
yq '.streams[].vars[] | select(.name == "ssl*") | .description'  packages/*/data_stream/*/manifest.yml
  • List all unique descriptions
yq '.streams[].vars[] | select(.name == "ssl*") | .description'  packages/*/data_stream/*/manifest.yml | sort -u
  • Find integrations that are metrics and print description
yq 'select(.type == "*metrics*") | .streams[].vars[] | select(.name == "ssl*") | .description ' packages/*/data_stream/*/manifest.yml | sort -u
  • Find integrations that synthetics and print description
yq 'select(.type == "*synthetics*") | .streams[].vars[] | select(.name == "ssl*") | .description ' packages/*/data_stream/*/manifest.yml | sort -u

Related Issues

@StacieClark-Elastic
docs/11792-add-link-to-ssl-online-reference
d982fb1 
updated ssl entries in manifest.yml files to have uniform text and to point to online documentation for ssl options
@StacieClark-Elastic StacieClark-Elastic added enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Jan 27, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@StacieClark-Elastic StacieClark-Elastic requested review from a team as code owners January 27, 2025 20:59
@StacieClark-Elastic
docs/11792-add-link-to-ssl-online-reference
0bc31b7 
updated pull request number in changelog.yml files
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 27, 2025 •
edited
Loading

🚀 Benchmarks report

Package 1password 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
signin_attempts 6060.61 4975.12 -1085.49 (-17.91%) 💔

Package abnormal_security 👍(0) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
case 6666.67 5464.48 -1202.19 (-18.03%) 💔

Package activemq 👍(1) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
topic 111111.11 55555.56 -55555.55 (-50%) 💔

Package apache 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 4524.89 3676.47 -848.42 (-18.75%) 💔

Package apache_tomcat 👍(4) 💚(4) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cache 25000 17543.86 -7456.14 (-29.82%) 💔

Package authentik 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
group 6896.55 4739.34 -2157.21 (-31.28%) 💔

Package aws 👍(13) 💚(2) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
route53_public_logs 19230.77 13513.51 -5717.26 (-29.73%) 💔
ec2_logs 33333.33 27777.78 -5555.55 (-16.67%) 💔
emr_logs 18518.52 10416.67 -8101.85 (-43.75%) 💔
firewall_logs 3597.12 2518.89 -1078.23 (-29.97%) 💔

Package bitwarden 👍(3) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
policy 7407.41 5988.02 -1419.39 (-19.16%) 💔

Package canva 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 751.88 555.86 -196.02 (-26.07%) 💔

Package ceph 👍(2) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cluster_status 7042.25 4166.67 -2875.58 (-40.83%) 💔
osd_pool_stats 23809.52 19230.77 -4578.75 (-19.23%) 💔
osd_tree 22222.22 14084.51 -8137.71 (-36.62%) 💔

Package cisco_meraki 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 500000 333333.33 -166666.67 (-33.33%) 💔

Package cisco_secure_endpoint 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 3333.33 1960.78 -1372.55 (-41.18%) 💔

Package citrix_adc 👍(3) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
lbvserver 7812.5 6060.61 -1751.89 (-22.42%) 💔
log 874.89 723.07 -151.82 (-17.35%) 💔
system 6289.31 5128.21 -1161.1 (-18.46%) 💔

Package cloudflare_logpush 👍(10) 💚(4) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
magic_ids 12345.68 9803.92 -2541.76 (-20.59%) 💔
nel_report 31250 23255.81 -7994.19 (-25.58%) 💔
network_session 4830.92 3623.19 -1207.73 (-25%) 💔
casb 6802.72 5000 -1802.72 (-26.5%) 💔

Package couchbase 👍(6) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cluster 16129.03 12048.19 -4080.84 (-25.3%) 💔
query_index 9259.26 6493.51 -2765.75 (-29.87%) 💔

Package couchdb 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
server 4081.63 3236.25 -845.38 (-20.71%) 💔

Package crowdstrike 👍(2) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 1210.65 1018.33 -192.32 (-15.89%) 💔
falcon 12195.12 9174.31 -3020.81 (-24.77%) 💔

Package cyberarkpas 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 1519.76 1264.22 -255.54 (-16.81%) 💔

Package cybereason 👍(2) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
malware 7042.25 3496.5 -3545.75 (-50.35%) 💔
suspicions_process 1497.01 896.06 -600.95 (-40.14%) 💔

Package elasticsearch 👍(1) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
gc 4608.29 2898.55 -1709.74 (-37.1%) 💔
server 6756.76 3731.34 -3025.42 (-44.78%) 💔
slowlog 5405.41 4016.06 -1389.35 (-25.7%) 💔

Package eset_protect 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
detection 1838.24 1398.6 -439.64 (-23.92%) 💔

Package forgerock 👍(1) 💚(5) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
am_access 5524.86 3355.7 -2169.16 (-39.26%) 💔
am_config 14084.51 11764.71 -2319.8 (-16.47%) 💔
idm_access 9259.26 6896.55 -2362.71 (-25.52%) 💔
idm_activity 23809.52 17543.86 -6265.66 (-26.32%) 💔
idm_authentication 20000 13888.89 -6111.11 (-30.56%) 💔

Package github 👍(1) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
code_scanning 4672.9 3745.32 -927.58 (-19.85%) 💔
secret_scanning 9523.81 6896.55 -2627.26 (-27.59%) 💔

Package google_scc 👍(1) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 1051.52 877.19 -174.33 (-16.58%) 💔
audit 2341.92 1600 -741.92 (-31.68%) 💔
source 28571.43 19230.77 -9340.66 (-32.69%) 💔

Package google_workspace 👍(11) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
user_accounts 15384.62 11764.71 -3619.91 (-23.53%) 💔
chrome 1481.48 1218.03 -263.45 (-17.78%) 💔
device 1464.13 1230.01 -234.12 (-15.99%) 💔
drive 5235.6 2785.52 -2450.08 (-46.8%) 💔

Package hadoop 👍(3) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
application 5952.38 4566.21 -1386.17 (-23.29%) 💔
node_manager 20000 9803.92 -10196.08 (-50.98%) 💔

Package hashicorp_vault 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 4201.68 3484.32 -717.36 (-17.07%) 💔
log 11235.96 6756.76 -4479.2 (-39.86%) 💔

Package imperva 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
securesphere 3717.47 2617.8 -1099.67 (-29.58%) 💔

Package infoblox_bloxone_ddi 👍(0) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dhcp_lease 3636.36 2976.19 -660.17 (-18.15%) 💔
dns_config 1216.55 905.8 -310.75 (-25.54%) 💔

Package jamf_compliance_reporter 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1140.25 907.44 -232.81 (-20.42%) 💔

Package jumpcloud 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 2865.33 2096.44 -768.89 (-26.83%) 💔

Package m365_defender 👍(3) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 477.78 354.36 -123.42 (-25.83%) 💔

Package menlo 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dlp 3571.43 2777.78 -793.65 (-22.22%) 💔

Package mysql 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
error 31250 15151.52 -16098.48 (-51.52%) 💔

Package nagios_xi 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 15151.52 12820.51 -2331.01 (-15.38%) 💔
host 2762.43 2217.29 -545.14 (-19.73%) 💔

Package panw_cortex_xdr 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
incidents 6493.51 4424.78 -2068.73 (-31.86%) 💔

Package ping_federate 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 3787.88 3164.56 -623.32 (-16.46%) 💔

Package ping_one 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2631.58 1908.4 -723.18 (-27.48%) 💔

Package pps 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 4310.34 3076.92 -1233.42 (-28.62%) 💔

Package prisma_access 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 592.07 498.75 -93.32 (-15.76%) 💔

Package prisma_cloud 👍(1) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
host 454.75 330.69 -124.06 (-27.28%) 💔
incident_audit 2564.1 2169.2 -394.9 (-15.4%) 💔

Package pulse_connect_secure 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 3174.6 2463.05 -711.55 (-22.41%) 💔

Package qualys_vmdr 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset_host_detection 993.05 690.61 -302.44 (-30.46%) 💔

Package rapid7_insightvm 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vulnerability 4484.3 3610.11 -874.19 (-19.49%) 💔

Package rubrik 👍(4) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
managed_volumes 20833.33 16666.67 -4166.66 (-20%) 💔
physical_hosts 41666.67 24390.24 -17276.43 (-41.46%) 💔

Package spycloud 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
breach_catalog 1170.96 972.76 -198.2 (-16.93%) 💔

Package sublime_security 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
message_event 7812.5 4807.69 -3004.81 (-38.46%) 💔

Package sysdig 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 3401.36 2469.14 -932.22 (-27.41%) 💔

Package system 👍(0) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
security 2688.17 1841.62 -846.55 (-31.49%) 💔
syslog 333333.33 250000 -83333.33 (-25%) 💔

Package tanium 👍(2) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
client_status 8130.08 6289.31 -1840.77 (-22.64%) 💔
endpoint_config 15873.02 10204.08 -5668.94 (-35.71%) 💔

Package tenable_io 👍(1) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 1280.41 948.77 -331.64 (-25.9%) 💔
scan 17857.14 11235.96 -6621.18 (-37.08%) 💔

Package thycotic_ss 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
logs 3215.43 2288.33 -927.1 (-28.83%) 💔

Package ti_anomali 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threatstream 4784.69 3816.79 -967.9 (-20.23%) 💔

Package ti_crowdstrike 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
intel 1721.17 1340.48 -380.69 (-22.12%) 💔
ioc 4566.21 3267.97 -1298.24 (-28.43%) 💔

Package tines 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit_logs 4065.04 3184.71 -880.33 (-21.66%) 💔

Package trellix_edr_cloud 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 1228.5 949.67 -278.83 (-22.7%) 💔

Package trellix_epo_cloud 👍(0) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
device 2739.73 1960.78 -778.95 (-28.43%) 💔
group 15625 10526.32 -5098.68 (-32.63%) 💔

Package trend_micro_vision_one 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 6451.61 4672.9 -1778.71 (-27.57%) 💔

Package vsphere 👍(2) 💚(2) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cluster 28571.43 21739.13 -6832.3 (-23.91%) 💔
datastorecluster 50000 40000 -10000 (-20%) 💔
log 4608.29 3436.43 -1171.86 (-25.43%) 💔
virtualmachine 50000 33333.33 -16666.67 (-33.33%) 💔

Package windows 👍(2) 💚(4) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
applocker_packaged_app_deployment 13157.89 10309.28 -2848.61 (-21.65%) 💔
forwarded 1206.27 1019.37 -186.9 (-15.49%) 💔
sysmon_operational 2985.07 2288.33 -696.74 (-23.34%) 💔

Package wiz 👍(2) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 3012.05 2403.85 -608.2 (-20.19%) 💔
cloud_configuration_finding 4545.45 3816.79 -728.66 (-16.03%) 💔

Package zeek 👍(26) 💚(7) 💔(10)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
http 41666.67 27777.78 -13888.89 (-33.33%) 💔
modbus 31250 17857.14 -13392.86 (-42.86%) 💔
ntp 52631.58 40000 -12631.58 (-24%) 💔
radius 13698.63 11494.25 -2204.38 (-16.09%) 💔
snmp 32258.06 27027.03 -5231.03 (-16.22%) 💔
stats 19607.84 15625 -3982.84 (-20.31%) 💔
dce_rpc 15873.02 11494.25 -4378.77 (-27.59%) 💔
dhcp 16393.44 11627.91 -4765.53 (-29.07%) 💔
dnp3 20408.16 12820.51 -7587.65 (-37.18%) 💔
dpd 21276.6 13888.89 -7387.71 (-34.72%) 💔

Package zscaler_zpa 👍(2) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
app_connector_status 2380.95 1855.29 -525.66 (-22.08%) 💔
browser_access 2320.19 1564.95 -755.24 (-32.55%) 💔
user_status 6756.76 3759.4 -2997.36 (-44.36%) 💔

To see the full report comment with /test benchmark fullreport

@StacieClark-Elastic StacieClark-Elastic changed the title [Integrations] make ssl description in manifest.yml uniform with links to online documentation DRAFT [Integrations] make ssl description in manifest.yml uniform with links to online documentation Jan 27, 2025
andrewkroh
andrewkroh reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice to have some uniformity for this and to also point to reference docs for the options. This will help users. 👍

It shouldn't matter that some non-Filebeat based inputs (like synthetics/http or activemq/metrics) point to the Filebeat SSL docs because this documentation shared content between the beats. But it might avoid some confusion if we tailor the links based on the input. e.g.

packages/zscaler_zpa/changelog.yml Outdated Show resolved Hide resolved
packages/zoom/data_stream/webhook/manifest.yml Outdated Show resolved Hide resolved
@StacieClark-Elastic
docs/11792-add-link-to-ssl-online-reference
06f3ce6 
fixed incorrect version number in changelog.yml
3kt
3kt approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@3kt 3kt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT elastic/customer-architects

efd6
efd6 reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit then LGTM

packages/abnormal_security/changelog.yml Outdated Show resolved Hide resolved
@StacieClark-Elastic
docs/11792-add-link-to-ssl-online-reference
93958a6 
fixed missed change from enhancement to bugfix
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@qcorporation qcorporation force-pushed the docs/11792-add-link-to-ssl-online-reference branch from 025dca6 to bb820e5 Compare February 3, 2025 22:34
@qcorporation qcorporation requested review from a team as code owners February 3, 2025 22:34
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Feb 3, 2025
gizas
gizas reviewed Feb 4, 2025
View reviewed changes
packages/kubernetes/data_stream/apiserver/manifest.yml
@@ -40,6 +40,7 @@ streams:
multi: true
required: true
show_user: true
description: SSL certificate authorities. See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: SSL certificate authorities. See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.
description: SSL [certificate authorities](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#client-certificate-authorities). See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.

gizas
gizas reviewed Feb 4, 2025
View reviewed changes
packages/kubernetes/data_stream/container/manifest.yml
@@ -37,6 +37,7 @@ streams:
- name: ssl.verification_mode
type: text
title: SSL Verification Mode
description: SSL verification mode. See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: SSL verification mode. See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.
description: SSL [verification mode](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#client-verification-mode). See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.

gizas
gizas reviewed Feb 4, 2025
View reviewed changes
packages/prometheus/data_stream/collector/manifest.yml
@@ -70,32 +70,38 @@ streams:
- name: ssl.verification_mode
type: text
title: SSL Verification Mode
description: SSL verification mode. See [documentation](https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#ssl-common-config) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as with Kubernetes. Shall we inlcude link to https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-ssl.html#client-verification-mode?

Same to below options?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered adding the more specific links originally. I didn't include them due to concerns that the more specific links might get broken with document updates. The package belongs to you. I'll put anything you want in the description

@StacieClark-Elastic StacieClark-Elastic force-pushed the docs/11792-add-link-to-ssl-online-reference branch from bb820e5 to fa2175f Compare February 4, 2025 17:17
@qcorporation qcorporation force-pushed the docs/11792-add-link-to-ssl-online-reference branch from fa2175f to 787b521 Compare February 4, 2025 18:14
@elasticmachine
Copy link

💔 Build Failed

Failed CI Steps

History

@StacieClark-Elastic
Copy link
Member Author

closing PR. Will create new PRs by code owner on forked repo

@StacieClark-Elastic StacieClark-Elastic deleted the docs/11792-add-link-to-ssl-online-reference branch February 4, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas left review comments

@efd6 efd6 efd6 left review comments

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@consulthys consulthys consulthys approved these changes

@cmacknz cmacknz cmacknz approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@3kt 3kt 3kt approved these changes

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@chemamartinez chemamartinez chemamartinez approved these changes

@mauri870 mauri870 Awaiting requested review from mauri870 mauri870 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees
No one assigned
Labels
enhancement New feature or request Integration:abnormal_security Abnormal Security Integration:activemq ActiveMQ Integration:akamai Akamai Integration:amazon_security_lake Amazon Security Lake Integration:apache_tomcat Apache Tomcat Integration:apache Apache HTTP Server Integration:atlassian_bitbucket Atlassian Bitbucket Integration:atlassian_confluence Atlassian Confluence Integration:atlassian_jira Atlassian Jira Integration:auth0 Auth0 Integration:authentik authentik Integration:aws AWS Integration:barracuda_cloudgen_firewall Barracuda CloudGen Firewall Logs Integration:barracuda Barracuda Web Application Firewall Integration:bitdefender BitDefender Integration:bitwarden Bitwarden Integration:blacklens blacklens.io Integration:canva Canva Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:carbonblack_edr VMware Carbon Black EDR Integration:cef Common Event Format (CEF) Integration:ceph Ceph Integration:checkpoint_email Check Point Harmony Email & Collaboration Integration:checkpoint Check Point Integration:cisa_kevs CISA Known Exploited Vulnerabilities Integration:cisco_aironet Cisco Aironet Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_ise Cisco ISE Integration:cisco_meraki Cisco Meraki Integration:cisco_nexus Cisco Nexus Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:cisco_secure_endpoint Cisco Secure Endpoint Integration:citrix_adc Citrix ADC Integration:citrix_waf Citrix Web App Firewall Integration:claroty_ctd Claroty CTD Integration:cloudflare_logpush Cloudflare Logpush Integration:cloudflare Cloudflare Integration:cockroachdb CockroachDB Metrics Integration:couchbase Couchbase Integration:couchdb CouchDB Integration:crowdstrike CrowdStrike Integration:cyberark_epm CyberArk EPM Integration:cyberark_pta Cyberark Privileged Threat Analytics Integration:cyberarkpas CyberArk Privileged Access Security Integration:cybereason Cybereason Integration:darktrace Darktrace Integration:digital_guardian Digital Guardian Integration:elasticsearch Elasticsearch Integration:entityanalytics_entra_id Microsoft Entra ID Entity Analytics Integration:entityanalytics_okta Okta Entity Analytics Integration:eset_protect ESET PROTECT Integration:ess_billing Elasticsearch Service Billing Integration:etcd etcd Integration:f5_bigip F5 BIG-IP Integration:first_epss First EPSS Integration:forgerock ForgeRock Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Integration:fortinet_fortimail Fortinet FortiMail Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:fortinet_fortiproxy Fortinet FortiProxy Integration:github GitHub Integration:golang Golang Integration:google_scc Google Security Command Center Integration:google_workspace Google Workspace Integration:hadoop Hadoop Integration:hashicorp_vault Hashicorp Vault Integration:http_endpoint Custom HTTP Endpoint Logs Integration:ibmmq IBM MQ Integration:imperva_cloud_waf Imperva Cloud WAF Integration:imperva Imperva Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:infoblox_nios Infoblox NIOS Integration:jamf_compliance_reporter Jamf Compliance Reporter Integration:jamf_pro Jamf Pro Integration:jamf_protect Jamf Protect Integration:jolokia_input Jolokia Input Integration:jumpcloud JumpCloud Integration:juniper_srx Juniper SRX Integration:kafka_log Custom Kafka Logs Integration:kafka Kafka Integration:kibana Kibana Integration:kubernetes Kubernetes Integration:1password 1Password New Integration Issue or pull request for creating a new integration package. Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Integrations] Ensure that all 'ssl' configuration options have descriptions