-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jamf_protect: update manifest format version to v3.0.3 #9908
Conversation
Two ECS-defined fields are removed as they do not conform to ECS requirements. * In alerts, process.tty is removed since it is being used as a keyword while the ECS definition is an object. There is no obvious alternative ECS field for this value. * In web_traffic_events, interface.name is removed since it is being used at root. The ECS definition requires that it be under the observer.{egress,ingress} fields; these are not relevant to the document.
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
alerts |
1512.86 | 1199.04 | -313.82 (-20.74%) | 💔 |
telemetry |
1517.45 | 1129.94 | -387.51 (-25.54%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
cc @efd6 |
Quality Gate passedIssues Measures |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
LGTM 👍🏼
packages/jamf_protect/data_stream/alerts/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
Package jamf_protect - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=jamf_protect |
Proposed commit message
See title.
Note removal of ECS fields. The probably best approach to address these issues would be to retain a jamf_protect object to hold items like these. This is not done in this change.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots