Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] [A11y][Crawler] Define radiogroups correctly in extraction rule…
…s flyout (#201191) (#201239) # Backport This will backport the following commits from `main` to `8.x`: - [[A11y][Crawler] Define radiogroups correctly in extraction rules flyout (#201191)](#201191) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jedr Blaszyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T16:38:43Z","message":"[A11y][Crawler] Define radiogroups correctly in extraction rules flyout (#201191)\n\n## Summary\r\n\r\nThe issue: keyboard nav with tab doesn't jump between radiogroups\r\ncorrectly, instead skips some.\r\n\r\nFix the issue with radiogroups selection with `TAB`, following the EUI\r\ndocs:\r\nhttps://eui.elastic.co/#/forms/selection-controls#radio-group\r\n\r\nWe need to\r\n> Pass a single `name` property to define the group.\r\n\r\nTested locally that this is the culprit of issues when rendering\r\nmultiple radio groups in the same flyout.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"71667b0fb002098ba7ae599c43ca88d401020a04","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[A11y][Crawler] Define radiogroups correctly in extraction rules flyout","number":201191,"url":"https://github.com/elastic/kibana/pull/201191","mergeCommit":{"message":"[A11y][Crawler] Define radiogroups correctly in extraction rules flyout (#201191)\n\n## Summary\r\n\r\nThe issue: keyboard nav with tab doesn't jump between radiogroups\r\ncorrectly, instead skips some.\r\n\r\nFix the issue with radiogroups selection with `TAB`, following the EUI\r\ndocs:\r\nhttps://eui.elastic.co/#/forms/selection-controls#radio-group\r\n\r\nWe need to\r\n> Pass a single `name` property to define the group.\r\n\r\nTested locally that this is the culprit of issues when rendering\r\nmultiple radio groups in the same flyout.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"71667b0fb002098ba7ae599c43ca88d401020a04"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201191","number":201191,"mergeCommit":{"message":"[A11y][Crawler] Define radiogroups correctly in extraction rules flyout (#201191)\n\n## Summary\r\n\r\nThe issue: keyboard nav with tab doesn't jump between radiogroups\r\ncorrectly, instead skips some.\r\n\r\nFix the issue with radiogroups selection with `TAB`, following the EUI\r\ndocs:\r\nhttps://eui.elastic.co/#/forms/selection-controls#radio-group\r\n\r\nWe need to\r\n> Pass a single `name` property to define the group.\r\n\r\nTested locally that this is the culprit of issues when rendering\r\nmultiple radio groups in the same flyout.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"71667b0fb002098ba7ae599c43ca88d401020a04"}}]}] BACKPORT--> Co-authored-by: Jedr Blaszyk <[email protected]>
- Loading branch information
1 parent
9fba1fa
commit 0c60c52