-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution][Alert details] - bring back last alert status cha…
…nge to flyout
- Loading branch information
1 parent
c382c20
commit 1a99cc5
Showing
7 changed files
with
169 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...s/security_solution/public/flyout/document_details/right/components/alert_status.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React from 'react'; | ||
import { act, render } from '@testing-library/react'; | ||
import { AlertStatus } from './alert_status'; | ||
import { mockContextValue } from '../../shared/mocks/mock_context'; | ||
import { DocumentDetailsContext } from '../../shared/context'; | ||
import { WORKFLOW_STATUS_DETAILS_TEST_ID, WORKFLOW_STATUS_TITLE_TEST_ID } from './test_ids'; | ||
import { TestProviders } from '../../../../common/mock'; | ||
import { useBulkGetUserProfiles } from '../../../../common/components/user_profiles/use_bulk_get_user_profiles'; | ||
|
||
jest.mock('../../../../common/components/user_profiles/use_bulk_get_user_profiles'); | ||
|
||
const renderAlertStatus = (contextValue: DocumentDetailsContext) => | ||
render( | ||
<TestProviders> | ||
<DocumentDetailsContext.Provider value={contextValue}> | ||
<AlertStatus /> | ||
</DocumentDetailsContext.Provider> | ||
</TestProviders> | ||
); | ||
|
||
const mockUserProfiles = [ | ||
{ uid: 'user-id-1', enabled: true, user: { username: 'user1', full_name: 'User 1' }, data: {} }, | ||
]; | ||
|
||
describe('<AlertStatus />', () => { | ||
beforeEach(() => { | ||
jest.clearAllMocks(); | ||
}); | ||
|
||
it('should render alert status history information', async () => { | ||
(useBulkGetUserProfiles as jest.Mock).mockReturnValue({ | ||
isLoading: false, | ||
data: mockUserProfiles, | ||
}); | ||
const contextValue = { | ||
...mockContextValue, | ||
getFieldsData: jest.fn().mockImplementation((field: string) => { | ||
if (field === 'kibana.alert.workflow_user') return ['user-id-1']; | ||
if (field === 'kibana.alert.workflow_status_updated_at') | ||
return ['2023-11-01T22:33:26.893Z']; | ||
}), | ||
}; | ||
|
||
const { getByTestId } = renderAlertStatus(contextValue); | ||
|
||
await act(async () => { | ||
expect(getByTestId(WORKFLOW_STATUS_TITLE_TEST_ID)).toBeInTheDocument(); | ||
expect(getByTestId(WORKFLOW_STATUS_DETAILS_TEST_ID)).toBeInTheDocument(); | ||
}); | ||
}); | ||
|
||
it('should render empty component if missing workflow_user value', async () => { | ||
const { container } = renderAlertStatus(mockContextValue); | ||
|
||
await act(async () => { | ||
expect(container).toBeEmptyDOMElement(); | ||
}); | ||
}); | ||
}); |
61 changes: 61 additions & 0 deletions
61
...lugins/security_solution/public/flyout/document_details/right/components/alert_status.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui'; | ||
import { getUserDisplayName } from '@kbn/user-profile-components'; | ||
import { FormattedMessage } from '@kbn/i18n-react'; | ||
import type { FC } from 'react'; | ||
import React from 'react'; | ||
import { WORKFLOW_STATUS_DETAILS_TEST_ID, WORKFLOW_STATUS_TITLE_TEST_ID } from './test_ids'; | ||
import { useBulkGetUserProfiles } from '../../../../common/components/user_profiles/use_bulk_get_user_profiles'; | ||
import { PreferenceFormattedDate } from '../../../../common/components/formatted_date'; | ||
import { useDocumentDetailsContext } from '../../shared/context'; | ||
import { getField } from '../../shared/utils'; | ||
|
||
/** | ||
* Displays info about who last updated the alert's workflow status and when. | ||
*/ | ||
export const AlertStatus: FC = () => { | ||
const { getFieldsData } = useDocumentDetailsContext(); | ||
const statusUpdatedBy = getFieldsData('kibana.alert.workflow_user'); | ||
const statusUpdatedAt = getField(getFieldsData('kibana.alert.workflow_status_updated_at')); | ||
|
||
const result = useBulkGetUserProfiles({ uids: new Set(statusUpdatedBy) }); | ||
const user = result.data?.[0]?.user; | ||
|
||
if (!statusUpdatedBy || !statusUpdatedAt || result.isLoading || user == null) { | ||
return null; | ||
} | ||
|
||
return ( | ||
<EuiFlexGroup direction="column" gutterSize="s"> | ||
<EuiSpacer size="xs" /> | ||
<EuiFlexItem data-test-subj={WORKFLOW_STATUS_TITLE_TEST_ID}> | ||
<EuiTitle size="xxs"> | ||
<h5> | ||
<FormattedMessage | ||
id="xpack.securitySolution.flyout.right.about.status.statusHistoryTitle" | ||
defaultMessage="Last alert status change" | ||
/> | ||
</h5> | ||
</EuiTitle> | ||
</EuiFlexItem> | ||
<EuiFlexItem data-test-subj={WORKFLOW_STATUS_DETAILS_TEST_ID}> | ||
<FormattedMessage | ||
id="xpack.securitySolution.flyout.right.about.status.statusHistoryDetails" | ||
defaultMessage="Alert status updated by {user} on {date}" | ||
values={{ | ||
user: getUserDisplayName(user), | ||
date: <PreferenceFormattedDate value={new Date(statusUpdatedAt)} />, | ||
}} | ||
/> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
); | ||
}; | ||
|
||
AlertStatus.displayName = 'AlertStatus'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters