Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] [Security Solution][Alert Details] - fix some UI issues related…
… to emotion/css vs emotion/react (#205664) (#205928) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Alert Details] - fix some UI issues related to emotion/css vs emotion/react (#205664)](#205664) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:00:28Z","message":"[Security Solution][Alert Details] - fix some UI issues related to emotion/css vs emotion/react (#205664)\n\n## Summary\r\n\r\nThis recent [PR](#205011) slightly\r\nbroke the UI in a couple of small places in the alert details flyout.\r\nStrangely, I did review the PR by pulling down the branch, but only\r\nlooked at the places that were impacted by the files modified. The\r\ncouple of places where the UI broke were completely different...\r\nMy guess it is is related to the fact that in those place we were still\r\nusing `@emotion/css` and this might not play nice with some\r\n`styled_components`...\r\n\r\nUpdating those places to use `@emotion/react` fixed the issues!\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-1](https://github.com/user-attachments/assets/839760db-da3c-4031-b4be-18645b37c089)\r\n|\r\n![fix-1](https://github.com/user-attachments/assets/cdfae85c-0e63-45be-94dd-5e0f9a698d8a)\r\n|\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-2](https://github.com/user-attachments/assets/22588529-5afd-491d-ab00-6e07593fb6f7)\r\n|\r\n![fix-2](https://github.com/user-attachments/assets/c078d814-1a33-49dc-aa0d-25dcff555de2)\r\n|\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-3](https://github.com/user-attachments/assets/082d306c-8866-4e4f-ab18-db7c649101fe)\r\n|\r\n![fix-3](https://github.com/user-attachments/assets/5da76c44-934b-4a2a-a98e-2de34973d02e)\r\n|\r\n\r\nIn a follow work, we need to remove completely all the\r\n`styled_components` we have.","sha":"a8e1bf46a3dc111e37caf19b19897081ed2a8078","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0"],"title":"[Security Solution][Alert Details] - fix some UI issues related to emotion/css vs emotion/react","number":205664,"url":"https://github.com/elastic/kibana/pull/205664","mergeCommit":{"message":"[Security Solution][Alert Details] - fix some UI issues related to emotion/css vs emotion/react (#205664)\n\n## Summary\r\n\r\nThis recent [PR](#205011) slightly\r\nbroke the UI in a couple of small places in the alert details flyout.\r\nStrangely, I did review the PR by pulling down the branch, but only\r\nlooked at the places that were impacted by the files modified. The\r\ncouple of places where the UI broke were completely different...\r\nMy guess it is is related to the fact that in those place we were still\r\nusing `@emotion/css` and this might not play nice with some\r\n`styled_components`...\r\n\r\nUpdating those places to use `@emotion/react` fixed the issues!\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-1](https://github.com/user-attachments/assets/839760db-da3c-4031-b4be-18645b37c089)\r\n|\r\n![fix-1](https://github.com/user-attachments/assets/cdfae85c-0e63-45be-94dd-5e0f9a698d8a)\r\n|\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-2](https://github.com/user-attachments/assets/22588529-5afd-491d-ab00-6e07593fb6f7)\r\n|\r\n![fix-2](https://github.com/user-attachments/assets/c078d814-1a33-49dc-aa0d-25dcff555de2)\r\n|\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-3](https://github.com/user-attachments/assets/082d306c-8866-4e4f-ab18-db7c649101fe)\r\n|\r\n![fix-3](https://github.com/user-attachments/assets/5da76c44-934b-4a2a-a98e-2de34973d02e)\r\n|\r\n\r\nIn a follow work, we need to remove completely all the\r\n`styled_components` we have.","sha":"a8e1bf46a3dc111e37caf19b19897081ed2a8078"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205664","number":205664,"mergeCommit":{"message":"[Security Solution][Alert Details] - fix some UI issues related to emotion/css vs emotion/react (#205664)\n\n## Summary\r\n\r\nThis recent [PR](#205011) slightly\r\nbroke the UI in a couple of small places in the alert details flyout.\r\nStrangely, I did review the PR by pulling down the branch, but only\r\nlooked at the places that were impacted by the files modified. The\r\ncouple of places where the UI broke were completely different...\r\nMy guess it is is related to the fact that in those place we were still\r\nusing `@emotion/css` and this might not play nice with some\r\n`styled_components`...\r\n\r\nUpdating those places to use `@emotion/react` fixed the issues!\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-1](https://github.com/user-attachments/assets/839760db-da3c-4031-b4be-18645b37c089)\r\n|\r\n![fix-1](https://github.com/user-attachments/assets/cdfae85c-0e63-45be-94dd-5e0f9a698d8a)\r\n|\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-2](https://github.com/user-attachments/assets/22588529-5afd-491d-ab00-6e07593fb6f7)\r\n|\r\n![fix-2](https://github.com/user-attachments/assets/c078d814-1a33-49dc-aa0d-25dcff555de2)\r\n|\r\n\r\n| Before fix | After fix |\r\n| ------------- | ------------- |\r\n|\r\n![broken-3](https://github.com/user-attachments/assets/082d306c-8866-4e4f-ab18-db7c649101fe)\r\n|\r\n![fix-3](https://github.com/user-attachments/assets/5da76c44-934b-4a2a-a98e-2de34973d02e)\r\n|\r\n\r\nIn a follow work, we need to remove completely all the\r\n`styled_components` we have.","sha":"a8e1bf46a3dc111e37caf19b19897081ed2a8078"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
- Loading branch information