-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add check to fail CI if any dependencies are unowned (#206679)
## Summary - Updates `scripts/dependency_ownership` to use the `@kbn/dev-cli-runner` for consistency with other CI-related CLIs. - Adds a new `failIfUnowned` flag to exit with an error code if any dependencies are unowned. - Adds a new dependency ownership check to `quick_checks` and `renovate` CI steps. From a CI run, the additional quick check executes successfully in 3 seconds: ```sh info [quick-checks] Passed check: /opt/buildkite-agent/builds/bk-agent-prod-gcp-abc123/elastic/kibana-pull-request/kibana/.buildkite/scripts/steps/checks/dependencies_missing_owner.sh in 3s ``` --------- Co-authored-by: kibanamachine <[email protected]>
- Loading branch information
1 parent
2f6b9f6
commit 395e494
Showing
13 changed files
with
195 additions
and
207 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
.buildkite/scripts/steps/checks/dependencies_missing_owner.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
|
||
source .buildkite/scripts/common/util.sh | ||
|
||
echo --- Check for NPM dependencies missing owners | ||
node scripts/dependency_ownership.js --missingOwner --failIfUnowned |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.