remove unnecessary function invocation

elastic · Dec 17, 2024 · 545b572 · 545b572
1 parent b3124d7
commit 545b572
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 45 deletions.
diff --git a/src/plugins/share/public/components/tabs/embed/embed_content.test.tsx b/src/plugins/share/public/components/tabs/embed/embed_content.test.tsx
@@ -18,12 +18,7 @@ describe('Share modal embed content tab', () => {
 
     beforeEach(() => {
       component = mountWithIntl(
-        <EmbedContent
-          isDirty={false}
-          objectType="dashboard"
-          setIsNotSaved={() => jest.fn()}
-          shareableUrl="/home#/"
-        />
+        <EmbedContent isDirty={false} objectType="dashboard" shareableUrl="/home#/" />
       );
     });
 

diff --git a/src/plugins/share/public/components/tabs/embed/embed_content.tsx b/src/plugins/share/public/components/tabs/embed/embed_content.tsx
@@ -34,7 +34,6 @@ type EmbedProps = Pick<
   | 'objectType'
   | 'isDirty'
 > & {
-  setIsNotSaved: () => void;
   objectConfig?: ShareContextObjectTypeConfig;
 };
 
@@ -55,7 +54,6 @@ export const EmbedContent = ({
   shareableUrl,
   objectType,
   objectConfig = {},
-  setIsNotSaved,
   isDirty,
 }: EmbedProps) => {
   const isMounted = useMountedState();
@@ -67,10 +65,6 @@ export const EmbedContent = ({
   const [anonymousAccessParameters] = useState<AnonymousAccessState['accessURLParameters']>(null);
   const [usePublicUrl] = useState<boolean>(false);
 
-  useEffect(() => {
-    if (objectType !== 'dashboard') setIsNotSaved();
-  }, [url, setIsNotSaved, objectType]);
-
   const makeUrlEmbeddable = useCallback((tempUrl: string): string => {
     const embedParam = '?embed=true';
     const urlHasQueryString = tempUrl.indexOf('?') !== -1;

diff --git a/src/plugins/share/public/components/tabs/embed/index.tsx b/src/plugins/share/public/components/tabs/embed/index.tsx
@@ -8,35 +8,13 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import React, { useCallback } from 'react';
+import React from 'react';
 import { type IModalTabDeclaration } from '@kbn/shared-ux-tabbed-modal';
 import { EmbedContent } from './embed_content';
 import { useShareTabsContext } from '../../context';
 
-const EMBED_TAB_ACTIONS = {
-  SET_EMBED_URL: 'SET_EMBED_URL',
-  SET_IS_NOT_SAVED: 'SET_IS_NOT_SAVED',
-};
-
 type IEmbedTab = IModalTabDeclaration<{ url: string; isNotSaved: boolean }>;
 
-const embedTabReducer: IEmbedTab['reducer'] = (state = { url: '', isNotSaved: false }, action) => {
-  switch (action.type) {
-    case EMBED_TAB_ACTIONS.SET_IS_NOT_SAVED:
-      return {
-        ...state,
-        isNotSaved: action.payload,
-      };
-    case EMBED_TAB_ACTIONS.SET_IS_NOT_SAVED:
-      return {
-        ...state,
-        isNotSaved: action.payload,
-      };
-    default:
-      return state;
-  }
-};
-
 const EmbedTabContent: NonNullable<IEmbedTab['content']> = ({ state, dispatch }) => {
   const {
     embedUrlParamExtensions,
@@ -47,13 +25,6 @@ const EmbedTabContent: NonNullable<IEmbedTab['content']> = ({ state, dispatch })
     isDirty,
   } = useShareTabsContext()!;
 
-  const setIsNotSaved = useCallback(() => {
-    dispatch({
-      type: EMBED_TAB_ACTIONS.SET_IS_NOT_SAVED,
-      payload: objectType === 'dashboard' ? isDirty : false,
-    });
-  }, [dispatch, objectType, isDirty]);
-
   return (
     <EmbedContent
       {...{
@@ -62,8 +33,6 @@ const EmbedTabContent: NonNullable<IEmbedTab['content']> = ({ state, dispatch })
         shareableUrl,
         objectType,
         objectConfig: objectTypeMeta?.config?.embed,
-        isNotSaved: state?.isNotSaved,
-        setIsNotSaved,
         isDirty,
       }}
     />
@@ -75,6 +44,5 @@ export const embedTab: IEmbedTab = {
   name: i18n.translate('share.contextMenu.embedCodeTab', {
     defaultMessage: 'Embed',
   }),
-  reducer: embedTabReducer,
   content: EmbedTabContent,
 };