wip

x-pack/plugins/security_solution/public/management/components/artifact_list_page/components/artifact_flyout.tsx

@@ -26,6 +26,8 @@ import {
 import type { EuiFlyoutSize } from '@elastic/eui/src/components/flyout/flyout';
 import type { IHttpFetchError } from '@kbn/core-http-browser';
 import { useIsMounted } from '@kbn/securitysolution-hook-utils';
+import { useLocation } from 'react-router-dom';
+import type { EndpointInsightRouteState } from '../../../pages/endpoint_hosts/types';
 import { useUrlParams } from '../../../hooks/use_url_params';
 import { useIsFlyoutOpened } from '../hooks/use_is_flyout_opened';
 import { useTestIdGenerator } from '../../../hooks/use_test_id_generator';
@@ -196,7 +198,13 @@ export const ArtifactFlyout = memo<ArtifactFlyoutProps>(
       docLinks: {
         links: { securitySolution },
       },
+      application: { navigateToUrl },
     } = useKibana().services;
+
+    const location = useLocation<EndpointInsightRouteState>();
+    const [sourceInsight, setSourceInsight] = useState<{ id: string; back_url: string } | null>(
+      null
+    );
     const getTestId = useTestIdGenerator(dataTestSubj);
     const toasts = useToasts();
     const isFlyoutOpened = useIsFlyoutOpened();
@@ -293,15 +301,27 @@ export const ArtifactFlyout = memo<ArtifactFlyoutProps>(
             : labels.flyoutCreateSubmitSuccess(result)
         );
 
-        if (isMounted()) {
+        if (sourceInsight?.back_url) {
+          navigateToUrl(sourceInsight.back_url);
+        } else if (isMounted()) {
           // Close the flyout
           // `undefined` will cause params to be dropped from url
           setUrlParams({ ...urlParams, itemId: undefined, show: undefined }, true);
 
           onSuccess();
         }
       },
-      [isEditFlow, isMounted, labels, onSuccess, setUrlParams, toasts, urlParams]
+      [
+        isEditFlow,
+        isMounted,
+        labels,
+        navigateToUrl,
+        onSuccess,
+        setUrlParams,
+        sourceInsight?.back_url,
+        toasts,
+        urlParams,
+      ]
     );
 
     const handleSubmitClick = useCallback(() => {
@@ -357,6 +377,16 @@ export const ArtifactFlyout = memo<ArtifactFlyoutProps>(
       }
     }, [formState, confirmModalOnSuccess]);
 
+    // If this form was opened from an endpoint insight, prepopulate the form with the insight data
+    useEffect(() => {
+      if (location.state?.insight) {
+        setSourceInsight({ id: 'mocked', back_url: location.state.insight.back_url });
+        setFormState({ isValid: true, item: location.state.insight.item });
+
+        location.state.insight = undefined;
+      }
+    }, [apiClient.listId, location.state, location.state?.insight]);
+
     // If we don't have the actual Artifact data yet for edit (in initialization phase - ex. came in with an
     // ID in the url that was not in the list), then retrieve it now
     useEffect(() => {

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/types.ts

@@ -7,6 +7,7 @@
 
 import type { DataViewBase } from '@kbn/es-query';
 import type { GetInfoResponse } from '@kbn/fleet-plugin/common';
+import type { CreateExceptionListItemSchema } from '@kbn/securitysolution-io-ts-list-types';
 import type {
   AppLocation,
   EndpointPendingActions,
@@ -155,3 +156,10 @@ export interface TransformStatsResponse {
   count: number;
   transforms: TransformStats[];
 }
+
+export interface EndpointInsightRouteState {
+  insight?: {
+    back_url: string;
+    item: CreateExceptionListItemSchema;
+  };
+}

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/details/components/insights/workflow_insights_results.tsx

@@ -22,6 +22,10 @@ import { WORKFLOW_INSIGHTS } from '../../../translations';
 interface WorkflowInsightsResultsProps {
   results: boolean;
 }
+import type { EndpointInsightRouteState } from '../../../../types';
+import { getEndpointDetailsPath } from '../../../../../../common/routing';
+import { useKibana } from '../../../../../../../common/lib/kibana';
+import { APP_PATH, TRUSTED_APPS_PATH } from '../../../../../../../../common/constants';
 
 const CustomEuiCallOut = styled(EuiCallOut)`
   & .euiButtonIcon {
@@ -32,9 +36,47 @@ const CustomEuiCallOut = styled(EuiCallOut)`
 export const WorkflowInsightsResults = ({ results }: WorkflowInsightsResultsProps) => {
   const [showEmptyResultsCallout, setShowEmptyResultsCallout] = useState(true);
   const hideEmptyStateCallout = () => setShowEmptyResultsCallout(false);
-  if (!results) {
-    return null;
-  }
+  const {
+    application: { navigateToUrl },
+  } = useKibana().services;
+
+  const openArtifactCreationPage = () => {
+    const url = `${APP_PATH}${TRUSTED_APPS_PATH}?show=create`;
+    const state: EndpointInsightRouteState = {
+      insight: {
+        back_url: `${APP_PATH}${getEndpointDetailsPath({
+          name: 'endpointDetails',
+          selected_endpoint: '69f8c984-56bb-4f5d-b6fc-2f5673d93ec9',
+        })}`,
+        item: {
+          comments: [],
+          description: 'Test',
+          entries: [
+            {
+              field: 'process.hash.*',
+              operator: 'included',
+              type: 'match',
+              value: 'aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d',
+            },
+          ],
+          list_id: 'endpoint_trusted_apps',
+          name: 'Test',
+          namespace_type: 'agnostic',
+          tags: ['policy:all'],
+          type: 'simple',
+          os_types: ['windows'],
+        },
+      },
+    };
+    navigateToUrl(url, {
+      state,
+    });
+  };
+
+  const onInsightClick = (e: React.MouseEvent<HTMLAnchorElement>) => {
+    e.preventDefault();
+    openArtifactCreationPage();
+  };
 
   return (
     <>
@@ -62,9 +104,8 @@ export const WorkflowInsightsResults = ({ results }: WorkflowInsightsResultsProp
           <EuiFlexItem grow={false} style={{ marginLeft: 'auto' }}>
             <EuiButtonIcon
               iconType="popout"
-              aria-label="External link"
-              href="https://google.com"
-              target="_blank"
+              href={`${APP_PATH}${TRUSTED_APPS_PATH}?show=create`}
+              onClick={onInsightClick}
             />
           </EuiFlexItem>
         </EuiFlexGroup>