-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution][Alert Details] - fix some UI issues related to em…
…otion/css vs emotion/react (#205664) ## Summary This recent [PR](#205011) slightly broke the UI in a couple of small places in the alert details flyout. Strangely, I did review the PR by pulling down the branch, but only looked at the places that were impacted by the files modified. The couple of places where the UI broke were completely different... My guess it is is related to the fact that in those place we were still using `@emotion/css` and this might not play nice with some `styled_components`... Updating those places to use `@emotion/react` fixed the issues! | Before fix | After fix | | ------------- | ------------- | | ![broken-1](https://github.com/user-attachments/assets/839760db-da3c-4031-b4be-18645b37c089) | ![fix-1](https://github.com/user-attachments/assets/cdfae85c-0e63-45be-94dd-5e0f9a698d8a) | | Before fix | After fix | | ------------- | ------------- | | ![broken-2](https://github.com/user-attachments/assets/22588529-5afd-491d-ab00-6e07593fb6f7) | ![fix-2](https://github.com/user-attachments/assets/c078d814-1a33-49dc-aa0d-25dcff555de2) | | Before fix | After fix | | ------------- | ------------- | | ![broken-3](https://github.com/user-attachments/assets/082d306c-8866-4e4f-ab18-db7c649101fe) | ![fix-3](https://github.com/user-attachments/assets/5da76c44-934b-4a2a-a98e-2de34973d02e) | In a follow work, we need to remove completely all the `styled_components` we have.
- Loading branch information
1 parent
3fd987c
commit a8e1bf4
Showing
6 changed files
with
14 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters