Skip to content

Commit

Permalink
[8.x] [Search] fix: ensure App Search is used for classic nav link na…
Browse files Browse the repository at this point in the history
…me (#203490) (#203642)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] fix: ensure App Search is used for classic nav link name
(#203490)](#203490)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T16:31:08Z","message":"[Search]
fix: ensure App Search is used for classic nav link name (#203490)\n\n##
Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav
link in classic\r\nmode over \"Engines\" which is the label for the
navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.18.0","v8.17.1"],"title":"[Search]
fix: ensure App Search is used for classic nav link
name","number":203490,"url":"https://github.com/elastic/kibana/pull/203490","mergeCommit":{"message":"[Search]
fix: ensure App Search is used for classic nav link name (#203490)\n\n##
Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav
link in classic\r\nmode over \"Engines\" which is the label for the
navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203490","number":203490,"mergeCommit":{"message":"[Search]
fix: ensure App Search is used for classic nav link name (#203490)\n\n##
Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav
link in classic\r\nmode over \"Engines\" which is the label for the
navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <[email protected]>
  • Loading branch information
kibanamachine and TattdCodeMonkey authored Dec 10, 2024
1 parent d01037c commit c2b428e
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
import { i18n } from '@kbn/i18n';
import type { ClassicNavItem } from '@kbn/search-navigation/public';

import { GETTING_STARTED_TITLE } from '../../../../common/constants';
import { GETTING_STARTED_TITLE, APP_SEARCH_PLUGIN } from '../../../../common/constants';

import { BuildClassicNavParameters } from '../types';

Expand Down Expand Up @@ -176,6 +176,7 @@ export const buildBaseClassicNavItems = ({
deepLink: {
link: 'appSearch:engines',
},
name: APP_SEARCH_PLUGIN.NAME,
id: 'app_search',
});
}
Expand Down

0 comments on commit c2b428e

Please sign in to comment.