[HTTP] Add server/browser side http.staticAssets service (#171003)

## Summary

Part of #170421

### 1. Introduce the `http.staticAssets` service

Which can be used to generate hrefs to Kibana's static assets in a
CDN-friendly way (based on the CDN url if defined in the config, and the
Kibana's basePath otherwise)

The service is exposed both on the browser and server-side.

For now a single API is exposed: `getPluginAssetHref`

```ts
// returns "/plugins/{pluginId}/assets/some_folder/asset.png" when CDN isn't configured
core.http.statisAssets.getPluginAssetHref('some_folder/asset.png');
```

### 2. Plug it on some of the `home` plugin assets

Adapt the sample data sets and tutorial schemas to use the service for
links to the associated assets

## How to test

#### 1. Edit`/etc/hosts`

add a line `127.0.0.1       local.cdn`

#### 2. Edit `kibana.yaml`

Add `server.cdn.url: "http://local.cdn:5601"`

#### 3. Boot kibana and navigate to sample data set installation

(if started in dev mode, use `--no-base-path`)

Confirm that the sample data set presentation images are pointing to the
CDN url and properly displayed:

<img width="1565" alt="Screenshot 2023-11-13 at 09 28 51"
src="https://github.com/elastic/kibana/assets/1532934/23a887af-00cb-400c-9ab1-511ba463495f">

---------

Co-authored-by: kibanamachine <[email protected]>

packages/core/application/core-application-browser-internal/src/application_service.tsx

@@ -13,7 +13,7 @@ import { createBrowserHistory, History } from 'history';
 
 import type { PluginOpaqueId } from '@kbn/core-base-common';
 import type { ThemeServiceStart } from '@kbn/core-theme-browser';
-import type { HttpSetup, HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpSetup, InternalHttpStart } from '@kbn/core-http-browser-internal';
 import type { Capabilities } from '@kbn/core-capabilities-common';
 import type { MountPoint } from '@kbn/core-mount-utils-browser';
 import type { OverlayStart } from '@kbn/core-overlays-browser';
@@ -46,15 +46,15 @@ import {
 import { registerAnalyticsContextProvider } from './register_analytics_context_provider';
 
 export interface SetupDeps {
-  http: HttpSetup;
+  http: InternalHttpSetup;
   analytics: AnalyticsServiceSetup;
   history?: History<any>;
   /** Used to redirect to external urls */
   redirectTo?: (path: string) => void;
 }
 
 export interface StartDeps {
-  http: HttpStart;
+  http: InternalHttpStart;
   analytics: AnalyticsServiceStart;
   theme: ThemeServiceStart;
   overlays: OverlayStart;

packages/core/application/core-application-browser-internal/src/utils/parse_app_url.test.ts

@@ -30,7 +30,7 @@ describe('parseAppUrl', () => {
 
   beforeEach(() => {
     apps = new Map();
-    basePath = new BasePath('/base-path');
+    basePath = new BasePath({ basePath: '/base-path' });
 
     createApp({
       id: 'foo',

packages/core/apps/core-apps-browser-internal/src/core_app.ts

@@ -10,7 +10,7 @@ import type { UnregisterCallback } from 'history';
 import type { CoreContext } from '@kbn/core-base-browser-internal';
 import type { InternalInjectedMetadataSetup } from '@kbn/core-injected-metadata-browser-internal';
 import type { DocLinksStart } from '@kbn/core-doc-links-browser';
-import type { HttpSetup, HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpSetup, InternalHttpStart } from '@kbn/core-http-browser-internal';
 import type { IUiSettingsClient } from '@kbn/core-ui-settings-browser';
 import type { NotificationsSetup, NotificationsStart } from '@kbn/core-notifications-browser';
 import { AppNavLinkStatus, type AppMountParameters } from '@kbn/core-application-browser';
@@ -27,15 +27,15 @@ import { renderApp as renderStatusApp } from './status';
 
 export interface CoreAppsServiceSetupDeps {
   application: InternalApplicationSetup;
-  http: HttpSetup;
+  http: InternalHttpSetup;
   injectedMetadata: InternalInjectedMetadataSetup;
   notifications: NotificationsSetup;
 }
 
 export interface CoreAppsServiceStartDeps {
   application: InternalApplicationStart;
   docLinks: DocLinksStart;
-  http: HttpStart;
+  http: InternalHttpStart;
   notifications: NotificationsStart;
   uiSettings: IUiSettingsClient;
 }

packages/core/apps/core-apps-browser-internal/src/errors/error_application.test.ts

@@ -22,7 +22,7 @@ describe('renderApp', () => {
   let unmount: () => void;
 
   beforeEach(() => {
-    basePath = new BasePath();
+    basePath = new BasePath({ basePath: '' });
     element = document.createElement('div');
     history = createMemoryHistory();
     unmount = renderApp(

packages/core/apps/core-apps-browser-internal/src/errors/public_base_url.tsx

@@ -12,7 +12,7 @@ import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 
 import type { DocLinksStart } from '@kbn/core-doc-links-browser';
-import type { HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import type { NotificationsStart } from '@kbn/core-notifications-browser';
 import { mountReactNode } from '@kbn/core-mount-utils-browser-internal';
 
@@ -21,7 +21,7 @@ export const MISSING_CONFIG_STORAGE_KEY = `core.warnings.publicBaseUrlMissingDis
 
 interface Deps {
   docLinks: DocLinksStart;
-  http: HttpStart;
+  http: InternalHttpStart;
   notifications: NotificationsStart;
   // Exposed for easier testing
   storage?: Storage;

packages/core/apps/core-apps-browser-internal/src/errors/url_overflow.test.ts

@@ -27,7 +27,7 @@ describe('url overflow detection', () => {
   let unlisten: any;
 
   beforeEach(() => {
-    basePath = new BasePath('/test-123');
+    basePath = new BasePath({ basePath: '/test-123' });
     history = createMemoryHistory();
     toasts = notificationServiceMock.createStartContract().toasts;
     uiSettings = uiSettingsServiceMock.createStartContract();

packages/core/apps/core-apps-browser-internal/src/status/lib/load_status.ts

@@ -189,7 +189,7 @@ export async function loadStatus({
   http,
   notifications,
 }: {
-  http: HttpSetup;
+  http: Pick<HttpSetup, 'get'>;
   notifications: NotificationsSetup;
 }) {
   let response: StatusResponse;

packages/core/apps/core-apps-browser-internal/src/status/render_app.tsx

@@ -10,13 +10,13 @@ import React from 'react';
 import ReactDOM from 'react-dom';
 import { I18nProvider } from '@kbn/i18n-react';
 import { CoreThemeProvider } from '@kbn/core-theme-browser-internal';
-import type { HttpSetup } from '@kbn/core-http-browser';
+import type { InternalHttpSetup } from '@kbn/core-http-browser-internal';
 import type { NotificationsSetup } from '@kbn/core-notifications-browser';
 import type { AppMountParameters } from '@kbn/core-application-browser';
 import { StatusApp } from './status_app';
 
 interface Deps {
-  http: HttpSetup;
+  http: InternalHttpSetup;
   notifications: NotificationsSetup;
 }
 

packages/core/apps/core-apps-browser-internal/src/status/status_app.tsx

@@ -10,13 +10,13 @@ import React, { Component } from 'react';
 import { EuiLoadingSpinner, EuiText, EuiPage, EuiPageBody, EuiSpacer } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n-react';
 import { i18n } from '@kbn/i18n';
-import type { HttpSetup } from '@kbn/core-http-browser';
+import type { InternalHttpSetup } from '@kbn/core-http-browser-internal';
 import type { NotificationsSetup } from '@kbn/core-notifications-browser';
 import { loadStatus, type ProcessedServerResponse } from './lib';
 import { MetricTiles, ServerStatus, StatusSection, VersionHeader } from './components';
 
 interface StatusAppProps {
-  http: HttpSetup;
+  http: InternalHttpSetup;
   notifications: NotificationsSetup;
 }
 

packages/core/capabilities/core-capabilities-browser-internal/src/capabilities_service.tsx

@@ -8,12 +8,12 @@
 
 import type { RecursiveReadonly } from '@kbn/utility-types';
 import { deepFreeze } from '@kbn/std';
-import type { HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import type { Capabilities } from '@kbn/core-capabilities-common';
 
 interface StartDeps {
   appIds: string[];
-  http: HttpStart;
+  http: InternalHttpStart;
 }
 
 /** @internal */

packages/core/capabilities/core-capabilities-browser-internal/tsconfig.json

@@ -14,9 +14,9 @@
   "kbn_references": [
     "@kbn/utility-types",
     "@kbn/std",
-    "@kbn/core-http-browser",
     "@kbn/core-http-browser-mocks",
-    "@kbn/core-capabilities-common"
+    "@kbn/core-capabilities-common",
+    "@kbn/core-http-browser-internal"
   ],
   "exclude": [
     "target/**/*",

packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx

@@ -16,7 +16,7 @@ import useObservable from 'react-use/lib/useObservable';
 import type { InternalInjectedMetadataStart } from '@kbn/core-injected-metadata-browser-internal';
 import type { AnalyticsServiceSetup } from '@kbn/core-analytics-browser';
 import { type DocLinksStart } from '@kbn/core-doc-links-browser';
-import type { HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import { mountReactNode } from '@kbn/core-mount-utils-browser-internal';
 import type { NotificationsStart } from '@kbn/core-notifications-browser';
 import type { InternalApplicationStart } from '@kbn/core-application-browser-internal';
@@ -63,7 +63,7 @@ export interface SetupDeps {
 export interface StartDeps {
   application: InternalApplicationStart;
   docLinks: DocLinksStart;
-  http: HttpStart;
+  http: InternalHttpStart;
   injectedMetadata: InternalInjectedMetadataStart;
   notifications: NotificationsStart;
   customBranding: CustomBrandingStart;

packages/core/chrome/core-chrome-browser-internal/src/nav_links/nav_links_service.ts

@@ -9,7 +9,8 @@
 import { sortBy } from 'lodash';
 import { BehaviorSubject, ReplaySubject } from 'rxjs';
 import { map, takeUntil } from 'rxjs/operators';
-import type { HttpStart, IBasePath } from '@kbn/core-http-browser';
+import type { IBasePath } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import type { PublicAppDeepLinkInfo, PublicAppInfo } from '@kbn/core-application-browser';
 import type { InternalApplicationStart } from '@kbn/core-application-browser-internal';
 import type { ChromeNavLinks } from '@kbn/core-chrome-browser';
@@ -18,7 +19,7 @@ import { toNavLink } from './to_nav_link';
 
 interface StartDeps {
   application: InternalApplicationStart;
-  http: HttpStart;
+  http: InternalHttpStart;
 }
 
 export class NavLinksService {

packages/core/chrome/core-chrome-browser-internal/src/project_navigation/project_navigation_service.ts

@@ -16,7 +16,7 @@ import {
   ChromeSetProjectBreadcrumbsParams,
   ChromeProjectNavigationNode,
 } from '@kbn/core-chrome-browser';
-import type { HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import {
   BehaviorSubject,
   Observable,
@@ -37,7 +37,7 @@ import { buildBreadcrumbs } from './breadcrumbs';
 interface StartDeps {
   application: InternalApplicationStart;
   navLinks: ChromeNavLinks;
-  http: HttpStart;
+  http: InternalHttpStart;
   chromeBreadcrumbs$: Observable<ChromeBreadcrumb[]>;
 }
 
@@ -59,7 +59,7 @@ export class ProjectNavigationService {
   }>({ breadcrumbs: [], params: { absolute: false } });
   private readonly stop$ = new ReplaySubject<void>(1);
   private application?: InternalApplicationStart;
-  private http?: HttpStart;
+  private http?: InternalHttpStart;
   private unlistenHistory?: () => void;
 
   public start({ application, navLinks, http, chromeBreadcrumbs$ }: StartDeps) {

packages/core/chrome/core-chrome-browser-internal/src/recently_accessed/recently_accessed_service.ts

@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import type { HttpSetup } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import type {
   ChromeRecentlyAccessed,
   ChromeRecentlyAccessedHistoryItem,
@@ -15,7 +15,7 @@ import { PersistedLog } from './persisted_log';
 import { createLogKey } from './create_log_key';
 
 interface StartDeps {
-  http: HttpSetup;
+  http: InternalHttpStart;
 }
 
 /** @internal */

packages/core/chrome/core-chrome-browser-internal/tsconfig.json

@@ -43,6 +43,7 @@
     "@kbn/core-analytics-browser",
     "@kbn/shared-ux-router",
     "@kbn/shared-ux-link-redirect-app",
+    "@kbn/core-http-browser-internal",
   ],
   "exclude": [
     "target/**/*",

packages/core/deprecations/core-deprecations-browser-internal/src/deprecations_service.ts

@@ -8,13 +8,13 @@
 
 import type { CoreService } from '@kbn/core-base-browser-internal';
 import type { DeprecationsServiceStart } from '@kbn/core-deprecations-browser';
-import type { HttpStart } from '@kbn/core-http-browser';
+import type { InternalHttpStart } from '@kbn/core-http-browser-internal';
 import { DeprecationsClient } from './deprecations_client';
 
 export class DeprecationsService implements CoreService<void, DeprecationsServiceStart> {
   public setup(): void {}
 
-  public start({ http }: { http: HttpStart }): DeprecationsServiceStart {
+  public start({ http }: { http: InternalHttpStart }): DeprecationsServiceStart {
     const deprecationsClient = new DeprecationsClient({ http });
 
     return {

packages/core/deprecations/core-deprecations-browser-internal/tsconfig.json

@@ -16,7 +16,8 @@
     "@kbn/core-http-browser",
     "@kbn/core-http-browser-mocks",
     "@kbn/core-deprecations-common",
-    "@kbn/core-deprecations-browser"
+    "@kbn/core-deprecations-browser",
+    "@kbn/core-http-browser-internal"
   ],
   "exclude": [
     "target/**/*",

packages/core/http/core-http-browser-internal/index.ts

@@ -8,3 +8,4 @@
 
 export { BasePath } from './src/base_path';
 export { HttpService } from './src/http_service';
+export type { InternalHttpSetup, InternalHttpStart } from './src/types';