Skip to content

Commit

Permalink
[Security Solution] - remove styled-components and cleanup for timeli…
Browse files Browse the repository at this point in the history
…ne header actions (#206694)

## Summary

Similar to [this previous
PR](#206523), this PR originally
aimed at replacing the usages styled-components with @emotion/react in
the security_solution/public/common/components/header_actions folder. I
quickly realized that a lot of props and event components were actually
not used at all, so a cleanup was welcome.

Absolutely no UI or behavior logic changes should be introduced by this
PR.

This PR will impact the tables in timeline, and the markdown use in
osquery.

The biggest code cleanup are:
- removing a couple of components related to the header actions used in
timeline
- removing random unused translations, constants or helper functions

#### Timeline query, correlation and pinned tabs

![Screenshot 2025-01-14 at 5 29
49 PM](https://github.com/user-attachments/assets/8c06c0f3-c323-4dd7-96d1-14357abc551d)

![Screenshot 2025-01-14 at 5 30
05 PM](https://github.com/user-attachments/assets/7332fbe2-8744-46d5-a5e8-bd056fba0375)

![Screenshot 2025-01-14 at 5 30
27 PM](https://github.com/user-attachments/assets/86053a20-f0e4-4f0a-8bdd-0c2678194903)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
PhilippeOberti authored Jan 15, 2025
1 parent ca77772 commit d9b9425
Show file tree
Hide file tree
Showing 23 changed files with 60 additions and 900 deletions.
6 changes: 0 additions & 6 deletions packages/kbn-babel-preset/styled_components_files.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -40160,7 +40160,6 @@
"xpack.securitySolution.timeline.callOut.immutable.message.description": "Ce modèle de chronologie prédéfinie ne peut pas être modifié. Pour effectuer des modifications, veuillez dupliquer ce modèle et effectuer les modifications dans le double du modèle.",
"xpack.securitySolution.timeline.callOut.unauthorized.message.description": "Vous pouvez utiliser Timeline pour étudier les événements, mais vous ne disposez pas des autorisations requises pour enregistrer les chronologies pour une utilisation ultérieure. Si vous avez besoin d'enregistrer les chronologies, contactez votre administrateur Kibana.",
"xpack.securitySolution.timeline.cancelDeleteNoteLabel": "Conserver la note",
"xpack.securitySolution.timeline.categoryTooltip": "Catégorie",
"xpack.securitySolution.timeline.dataTable.dropZoneTableLabel": "Abandonner la zone pour ajouter un champ en tant que colonne dans la table",
"xpack.securitySolution.timeline.dataTable.exitFullScreenButton": "Quitter le mode plein écran (échap)",
"xpack.securitySolution.timeline.dataTable.footer.autoRefreshActiveDescription": "Actualisation automatique active",
Expand All @@ -40172,35 +40171,24 @@
"xpack.securitySolution.timeline.defaultTimelineTitle": "Aucun",
"xpack.securitySolution.timeline.deleteNoteError": "Une erreur est survenue lors de la suppression de la note {error}",
"xpack.securitySolution.timeline.deleteNoteLabel": "Supprimer la note",
"xpack.securitySolution.timeline.descriptionTooltip": "Description",
"xpack.securitySolution.timeline.destination": "Destination",
"xpack.securitySolution.timeline.EqlQueryBarLabel": "Requête EQL",
"xpack.securitySolution.timeline.eventRenderersSwitch.title": "Outils de rendu d'événement",
"xpack.securitySolution.timeline.eventRenderersSwitch.warning": "L'activation des outils de rendu d'événement peut avoir un impact sur les performances de la table.",
"xpack.securitySolution.timeline.eventsSelect.actions.pinSelected": "Épingler la sélection",
"xpack.securitySolution.timeline.eventsSelect.actions.selectAll": "Tous",
"xpack.securitySolution.timeline.eventsSelect.actions.selectNone": "Aucune",
"xpack.securitySolution.timeline.eventsSelect.actions.selectPinned": "Épinglé",
"xpack.securitySolution.timeline.eventsSelect.actions.selectUnpinned": "Désépinglé",
"xpack.securitySolution.timeline.eventsSelect.actions.unpinSelected": "Désépingler la sélection",
"xpack.securitySolution.timeline.eventsTableAriaLabel": "événements ; page {activePage} sur {totalPages}",
"xpack.securitySolution.timeline.failDescription": "Une erreur s'est produite",
"xpack.securitySolution.timeline.failSearchDescription": "Impossible de lancer la recherche",
"xpack.securitySolution.timeline.fieldChooser.availableFieldsTooltip": "Champs disponibles pour l'affichage dans le tableau.",
"xpack.securitySolution.timeline.fieldChooser.timelineField.removeFieldTooltip": "Supprimer le champ du tableau",
"xpack.securitySolution.timeline.fieldTooltip": "Champ",
"xpack.securitySolution.timeline.file.fromOriginalPathDescription": "depuis son chemin d'origine",
"xpack.securitySolution.timeline.flyout.header.closeTimelineButtonLabel": "Fermer {isTimeline, select, true {la chronologie} other {le modèle}}",
"xpack.securitySolution.timeline.flyout.pane.removeColumnButtonLabel": "Supprimer la colonne",
"xpack.securitySolution.timeline.flyoutTimelineTemplateLabel": "Modèle de chronologie",
"xpack.securitySolution.timeline.footer.events": "Événements",
"xpack.securitySolution.timeline.footer.loadingLabel": "Chargement",
"xpack.securitySolution.timeline.footer.of": "de",
"xpack.securitySolution.timeline.footer.rows": "lignes",
"xpack.securitySolution.timeline.fullScreenButton": "Plein écran",
"xpack.securitySolution.timeline.graphOverlay.closeAnalyzerButton": "Fermer l'analyseur",
"xpack.securitySolution.timeline.graphOverlay.closeSessionButton": "Fermer le visualiseur de session",
"xpack.securitySolution.timeline.hideColumnLabel": "Masquer la colonne",
"xpack.securitySolution.timeline.kpiFailDescription": "Une erreur s'est produite",
"xpack.securitySolution.timeline.kpiFailSearchDescription": "Échec de chargement des KPI",
"xpack.securitySolution.timeline.kpis.destinationKpiTitle": "IP de destination",
Expand Down Expand Up @@ -40262,9 +40250,6 @@
"xpack.securitySolution.timeline.searchOrFilter.searchKqlSelectedText": "Rechercher",
"xpack.securitySolution.timeline.searchOrFilter.searchKqlTooltip": "Les événements des fournisseurs de données ci-dessus sont combinés avec les résultats de ce KQL",
"xpack.securitySolution.timeline.sidePanel.maxAnomalyScoreByJobTitle": "Score maximal d'anomalie par tâche",
"xpack.securitySolution.timeline.sortAZLabel": "Trier A-Z",
"xpack.securitySolution.timeline.sortFieldsButton": "Trier les champs",
"xpack.securitySolution.timeline.sortZALabel": "Trier Z-A",
"xpack.securitySolution.timeline.source": "Source",
"xpack.securitySolution.timeline.tabs.analyserTabTimelineTitle": "Analyseur",
"xpack.securitySolution.timeline.tabs.discoverEsqlInTimeline": "ES|QL",
Expand All @@ -40276,7 +40261,6 @@
"xpack.securitySolution.timeline.tabs.sessionTabTimelineTitle": "Vue de session",
"xpack.securitySolution.timeline.tcp": "TCP",
"xpack.securitySolution.timeline.toggleEventDetailsTitle": "Développer les détails de l'événement",
"xpack.securitySolution.timeline.typeTooltip": "Type",
"xpack.securitySolution.timeline.unsavedWorkMessage": "Quitter Timeline avec un travail non enregistré ?",
"xpack.securitySolution.timeline.unsavedWorkTitle": "Modifications non enregistrées",
"xpack.securitySolution.timeline.userDetails.managed.description": "Les métadonnées de toutes les intégrations de référentiel de ressource sont autorisées dans votre environnement.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40020,7 +40020,6 @@
"xpack.securitySolution.timeline.callOut.immutable.message.description": "この事前構築済みタイムラインテンプレートを修正することはできません。変更するには、このテンプレートを複製し、複製したテンプレートを修正します。",
"xpack.securitySolution.timeline.callOut.unauthorized.message.description": "タイムラインを使用すると、イベントを調査することができますが、今後使用する目的でタイムラインを保存するために必要な権限がありません。タイムラインを保存する必要がある場合は、Kibana管理者に連絡してください。",
"xpack.securitySolution.timeline.cancelDeleteNoteLabel": "メモを保持",
"xpack.securitySolution.timeline.categoryTooltip": "カテゴリー",
"xpack.securitySolution.timeline.dataTable.dropZoneTableLabel": "フィールドを列として表に追加するには、ゾーンをドロップします",
"xpack.securitySolution.timeline.dataTable.exitFullScreenButton": "全画面モードを終了(Esc)",
"xpack.securitySolution.timeline.dataTable.footer.autoRefreshActiveDescription": "自動更新アクション",
Expand All @@ -40032,35 +40031,24 @@
"xpack.securitySolution.timeline.defaultTimelineTitle": "なし",
"xpack.securitySolution.timeline.deleteNoteError": "メモの削除中にエラーが発生しました。{error}",
"xpack.securitySolution.timeline.deleteNoteLabel": "メモを削除",
"xpack.securitySolution.timeline.descriptionTooltip": "説明",
"xpack.securitySolution.timeline.destination": "送信先",
"xpack.securitySolution.timeline.EqlQueryBarLabel": "EQL クエリ",
"xpack.securitySolution.timeline.eventRenderersSwitch.title": "イベントレンダラー",
"xpack.securitySolution.timeline.eventRenderersSwitch.warning": "イベントレンダリングを有効化すると、テーブルパフォーマンスに影響する可能性があります。",
"xpack.securitySolution.timeline.eventsSelect.actions.pinSelected": "選択項目にピン付け",
"xpack.securitySolution.timeline.eventsSelect.actions.selectAll": "すべて",
"xpack.securitySolution.timeline.eventsSelect.actions.selectNone": "なし",
"xpack.securitySolution.timeline.eventsSelect.actions.selectPinned": "ピン付け済み",
"xpack.securitySolution.timeline.eventsSelect.actions.selectUnpinned": "ピンが外されました",
"xpack.securitySolution.timeline.eventsSelect.actions.unpinSelected": "選択項目のピンを外す",
"xpack.securitySolution.timeline.eventsTableAriaLabel": "イベント; {activePage}/{totalPages} ページ",
"xpack.securitySolution.timeline.failDescription": "エラーが発生しました",
"xpack.securitySolution.timeline.failSearchDescription": "検索を実行できませんでした",
"xpack.securitySolution.timeline.fieldChooser.availableFieldsTooltip": "フィールドをテーブルに表示できます。",
"xpack.securitySolution.timeline.fieldChooser.timelineField.removeFieldTooltip": "フィールドを表から削除",
"xpack.securitySolution.timeline.fieldTooltip": "フィールド",
"xpack.securitySolution.timeline.file.fromOriginalPathDescription": "元のパスから",
"xpack.securitySolution.timeline.flyout.header.closeTimelineButtonLabel": "{isTimeline, select, true {タイムライン} other {テンプレート}}を閉じる",
"xpack.securitySolution.timeline.flyout.pane.removeColumnButtonLabel": "列を削除",
"xpack.securitySolution.timeline.flyoutTimelineTemplateLabel": "タイムラインテンプレート",
"xpack.securitySolution.timeline.footer.events": "イベント",
"xpack.securitySolution.timeline.footer.loadingLabel": "読み込み中",
"xpack.securitySolution.timeline.footer.of": "/",
"xpack.securitySolution.timeline.footer.rows": "行",
"xpack.securitySolution.timeline.fullScreenButton": "全画面",
"xpack.securitySolution.timeline.graphOverlay.closeAnalyzerButton": "アナライザーを閉じる",
"xpack.securitySolution.timeline.graphOverlay.closeSessionButton": "セッションビューアーの終了",
"xpack.securitySolution.timeline.hideColumnLabel": "列を非表示",
"xpack.securitySolution.timeline.kpiFailDescription": "エラーが発生しました",
"xpack.securitySolution.timeline.kpiFailSearchDescription": "KPIの読み込みに失敗",
"xpack.securitySolution.timeline.kpis.destinationKpiTitle": "デスティネーション IP",
Expand Down Expand Up @@ -40122,9 +40110,6 @@
"xpack.securitySolution.timeline.searchOrFilter.searchKqlSelectedText": "検索",
"xpack.securitySolution.timeline.searchOrFilter.searchKqlTooltip": "上のデータプロバイダーからのイベントは、この KQL からの結果と組み合わされます。",
"xpack.securitySolution.timeline.sidePanel.maxAnomalyScoreByJobTitle": "ジョブ別の最高異常スコア",
"xpack.securitySolution.timeline.sortAZLabel": "A-Zの昇順で並べ替え",
"xpack.securitySolution.timeline.sortFieldsButton": "フィールドの並べ替え",
"xpack.securitySolution.timeline.sortZALabel": "ZーAの降順で並べ替え",
"xpack.securitySolution.timeline.source": "送信元",
"xpack.securitySolution.timeline.tabs.analyserTabTimelineTitle": "アナライザー",
"xpack.securitySolution.timeline.tabs.discoverEsqlInTimeline": "ES|QL",
Expand All @@ -40136,7 +40121,6 @@
"xpack.securitySolution.timeline.tabs.sessionTabTimelineTitle": "セッションビュー",
"xpack.securitySolution.timeline.tcp": "TCP",
"xpack.securitySolution.timeline.toggleEventDetailsTitle": "イベントの詳細を展開",
"xpack.securitySolution.timeline.typeTooltip": "型",
"xpack.securitySolution.timeline.unsavedWorkMessage": "作業を保存せずにタイムラインから移動しますか?",
"xpack.securitySolution.timeline.unsavedWorkTitle": "保存されていない変更",
"xpack.securitySolution.timeline.userDetails.managed.description": "環境で有効になっているアセットリポジトリ統合からのメタデータ。",
Expand Down
Loading

0 comments on commit d9b9425

Please sign in to comment.