-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Embeddable Rebuild] [Controls] Add
ignoreValidations
support to op…
…tions list control (#191303) Closes #191295 ## Summary This PR makes it so that the options list control respects the `ignoreParentSettings.ignoreValidations` setting when validating its selections: https://github.com/user-attachments/assets/abd41283-aafd-4802-8e2e-2f55d9551df3 Note that in the above video, we are "dropping" invalid selections in the UI when this setting is active, which means that the only way to unselect "empty" options is to click the "Show only selected" option in the UI. While I considered changing that behaviour in this PR, I opted to keep this PR as simple as possible by keeping the behaviour consistent with the non-React options list (i.e. the behaviour demonstrated in the video above is consistent with how options list work in Dashboards on `main`). We can always revisit that behaviour later, since it is a very easy change to make. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- Loading branch information
Showing
4 changed files
with
14 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters