-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric threshold rule alert on no data
appears unchecked in UI even if value is set to true
#183921
Comments
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Let's check to see if this mismatch appears with the other "alert if group disappears" value (this ticket references "alertOnNoData" which isn't tied to the "Alert me if a group stops reporting data" checkbox. Bigger question is whether we should ever let this value be "true" if there are no groups. Having a disabled checkbox marked "true" when it has no effect on the rule is also somewhat confusing. |
During refinement conversation, our recommendation is:
@maciejforcone @vinaychandrasekhar would love your thoughts on this |
I created a PR to fix the issue mentioned in this ticket: #188402 I think we can improve this logic more, as mentioned by @jasonrhodes, but I don't know how much effort we want to put into the metric threshold rule that hopefully will be deprecated in v9. Here is a documentation request for the custom threshold rule no data settings based on the new changes that @maciejforcone suggested: elastic/observability-docs#4068 |
…d rule (#188300) Fixes #188229, related to #183921 Documentation request: elastic/observability-docs#4068 ## Summary **Note**: I've added an item to deprecate/remove one of the no-data settings in v9. Fixes not showing no data setting and set the related settings to false by default. Based on @maciejforcone's input, we can combine these 2 settings for simplicity, as one of them works at a time. I also changed the tooltip according to which setting is relevant: (we use one action group for both of them in connectors) |No data (without group)|Missing group (with group)| |---|---| |![image](https://github.com/user-attachments/assets/ecf45dd2-d2a7-46ce-abd0-e2a07426f28e)|![image](https://github.com/user-attachments/assets/8dedd0fe-bb4b-4e51-808f-f65f54ee73fd)| Here is how the setting is applied in API: https://github.com/user-attachments/assets/52c52724-6011-4f6d-8464-023cd9a9ea10
For the metric threshold rule type, the option to "alert on no data" is disabled if no "group by" field is specified, but it defaults to
true
when the rule is created. This creates a confusing user experience because the field appears to be unchecked (false
) even when the value istrue
so users would have to inspect the rule configuration to know what the actual configuration isDisabled row in the UI where the option is unchecked. For this rule, the
alertOnNoData
rule param istrue
The text was updated successfully, but these errors were encountered: