Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metric threshold] Set missing group to false by default and show checkbox value in disable mode #188402

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Metric threshold] Set missing group to false by default and show checkbox value in disable mode #188402

merged 1 commit into from
Jul 17, 2024

Conversation

maryam-saeidi
Copy link
Member

Fixes #183921

Summary

  • Set the missing group value by default to false
  • Match the checkbox value to what is shown in the UI in the disable mode
Before After
image image

@maryam-saeidi maryam-saeidi self-assigned this Jul 16, 2024
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner July 16, 2024 08:49
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 16, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi
Copy link
Member Author

@ymao1 Does this match your expectations as described in this issue?

@maryam-saeidi maryam-saeidi mentioned this pull request Jul 16, 2024
Closed
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 16, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB -3.0B

History

cc @maryam-saeidi

@ymao1
Copy link
Contributor

ymao1 commented Jul 16, 2024

@ymao1 Does this match your expectations as described in this issue?

Yes thank you!

dominiqueclarke
dominiqueclarke approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maryam-saeidi maryam-saeidi merged commit 23732e6 into elastic:main Jul 17, 2024
31 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:fix v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric threshold rule alert on no data appears unchecked in UI even if value is set to true
6 participants
@maryam-saeidi @obltmachine @elasticmachine @ymao1 @dominiqueclarke @kibanamachine