Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet][EUI Visual refresh] Change usage of color success to accentSecondary where needed #201945

Closed
3 of 4 tasks
Tracked by #202008
criamico opened this issue Nov 27, 2024 · 5 comments
Closed
3 of 4 tasks
Tracked by #202008
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@criamico
Copy link
Contributor

criamico commented Nov 27, 2024

Context

The EUI team is introducing a new theme called "Borealis". As part of this change we need to update some colors in Fleet.
See parent issue: #199715 - it also contains the instructions to run the new theme (see section Instructions for updating and QA)

  • Check all occurrences of color success and change it to accentSecondary where applicable. We have roughly 20 occurrences of color "success" across Fleet. Details here
  • Check all occurrences of successText and change it to textSuccess or textAccentSecondary where applicable. Details here. It seems that we are not using this color in Fleet but as part of this work double check again if it's used and make changes accordingly.

Definitions of done

  • When testing the changes, test them both with the "old" Amsterdam theme and with the new Borealis theme.
  • Please label the PR with EUI Visual Refresh for cross-team visibility
@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jillguyonnet
Copy link
Contributor

jillguyonnet commented Dec 11, 2024

I went through all the occurrences within x-pack/plugins/fleet and believe there are no changes needed to meet this requirement (edit: found some occurrences of euiColorVis0, updating). Details below.

Check all occurrences of successText

There are no occurrences of this color token in Fleet code.

Check all occurrences of color success

There are 22 occurrences of color="success" in x-pack/plugins/fleet, all of which convey successful semantic meaning. This color is mainly used in callouts, health badges, buttons and status icons. Screenshots in Amsterdam theme below.

Agent policy creation confirmation:

Image

Agent enrollment:

color="success"
iconType="check"
>
{showViewAgents && (
<EuiButton
onClick={onButtonClick}
color="success"

and

Image

Agentless enrollment:

and

Image

Standalone agent install:

and

Image

ES requirements:

Image

Integration install (multipage layout):

Image

Add Fleet Server host + generate FS token:

and

Image

Agent health:

Image

Package policy ready to upgrade:

Image

Agent input health:

Image

Remote output health:

Image Image

@kpollich
Copy link
Member

Looks good to me, @jillguyonnet - thanks for being so thorough. We can close this as completed.

@jillguyonnet
Copy link
Contributor

jillguyonnet commented Dec 11, 2024

Sorry @kpollich I just found something that needs correcting that I had missed, reopening.

@jillguyonnet jillguyonnet reopened this Dec 11, 2024
@jillguyonnet
Copy link
Contributor

Double checked, what I found is relevant to #201997 and the use of euiColorVis0. Closing this one as the usage of success and successText have been reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants