-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet][EUI Visual refresh] Change usage of color success
to accentSecondary
where needed
#201945
Comments
Pinging @elastic/fleet (Team:Fleet) |
I went through all the occurrences within Check all occurrences of successTextThere are no occurrences of this color token in Fleet code. Check all occurrences of color successThere are 22 occurrences of Agent policy creation confirmation: Line 40 in 3683cc2
Agent enrollment: kibana/x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_agent_enrollment.tsx Lines 184 to 190 in 3683cc2
and kibana/x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_incoming_data.tsx Line 84 in 3683cc2
Agentless enrollment: Line 44 in 3683cc2
and kibana/x-pack/plugins/fleet/public/components/agentless_enrollment_flyout/step_confirm_data.tsx Line 57 in 3683cc2
Standalone agent install: Line 128 in 3683cc2
and Line 153 in 3683cc2
ES requirements: Line 42 in 3683cc2
Integration install (multipage layout): Line 148 in 3683cc2
Add Fleet Server host + generate FS token: Line 205 in 3683cc2
and kibana/x-pack/plugins/fleet/public/applications/fleet/components/generate_service_token.tsx Line 110 in 3683cc2
Agent health: kibana/x-pack/plugins/fleet/public/applications/fleet/sections/agents/components/agent_health.tsx Line 100 in 3683cc2
Package policy ready to upgrade: Line 138 in 3683cc2
Agent input health: Line 109 in 3683cc2
Remote output health: Line 73 in 3683cc2
|
Looks good to me, @jillguyonnet - thanks for being so thorough. We can close this as completed. |
Sorry @kpollich I just found something that needs correcting that I had missed, reopening. |
Double checked, what I found is relevant to #201997 and the use of |
Context
The EUI team is introducing a new theme called "Borealis". As part of this change we need to update some colors in Fleet.
See parent issue: #199715 - it also contains the instructions to run the new theme (see section
Instructions for updating and QA
)success
and change it toaccentSecondary
where applicable. We have roughly 20 occurrences of color "success" across Fleet. Details heresuccessText
and change it totextSuccess
ortextAccentSecondary
where applicable. Details here. It seems that we are not using this color in Fleet but as part of this work double check again if it's used and make changes accordingly.Definitions of done
EUI Visual Refresh
for cross-team visibilityThe text was updated successfully, but these errors were encountered: