Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Bulk action confirmation dialog should not mention "custom" rules #203149

Closed
Tracked by #201502
xcrzx opened this issue Dec 5, 2024 · 5 comments · Fixed by #204313
Closed
Tracked by #201502

[Security Solution] Bulk action confirmation dialog should not mention "custom" rules #203149

xcrzx opened this issue Dec 5, 2024 · 5 comments · Fixed by #204313
Assignees
@nikitaindik
Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Dec 5, 2024 •
edited by nikitaindik
Loading

PR: #204313

Summary

Rules are mistakenly labeled as custom even when they are prebuilt.

Steps to Reproduce

  1. Ensure rule customization is enabled
  2. Select all prebuilt rules in the rules management table
  3. Attempt to apply a bulk action, such as Add Index Patterns

Actual Result

A modal dialog appears stating that the action will only be applied to "X custom rules," even though no custom rules are installed.

Image

Expected Result

The dialog should not mention custom rules. Instead, it should correctly identify that the selected rules are prebuilt.
@xcrzx xcrzx added 8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Dec 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror banderror added v9.0.0 Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.17.0 v8.18.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed triage_needed labels Dec 5, 2024
@banderror banderror mentioned this issue Dec 5, 2024
Open
@banderror
Copy link
Contributor

@dplumlee While this one is low-impact, it looks a bit embarrassing and I think we should fix it soon.

@maximpn maximpn assigned nikitaindik and unassigned dplumlee Dec 6, 2024
@maximpn
Copy link
Contributor

maximpn commented Dec 6, 2024

@nikitaindik I assigned this one to you since it's an UI bug and you should have capacity to handle it.

@banderror banderror added v8.17.1 and removed v8.17.0 labels Dec 6, 2024
@nikitaindik nikitaindik mentioned this issue Dec 14, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 18, 2024
@nikitaindik
[Security Solution] Remove the word "custom" from bulk action modals (e…
ae4a2f9 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024

(cherry picked from commit 65bc6bc)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
@nikitaindik @JoseLuisGJ
[Security Solution] Remove the word "custom" from bulk action modals (e…
77d1d1b 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
benakansara pushed a commit to benakansara/kibana that referenced this issue Jan 2, 2025
@nikitaindik @benakansara
[Security Solution] Remove the word "custom" from bulk action modals (e…
82a4dff 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@nikitaindik @CAWilson94
[Security Solution] Remove the word "custom" from bulk action modals (e…
892fb36 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@nikitaindik @viduni94
[Security Solution] Remove the word "custom" from bulk action modals (e…
0e41b7a 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitaindik nikitaindik

Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Remove the word "custom" from bulk action modals nikitaindik/kibana
6 participants
@xcrzx @maximpn @banderror @elasticmachine @nikitaindik @dplumlee