Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove the word "custom" from bulk action modals #204313

Merged
merged 6 commits into from
Dec 18, 2024
Merged

[Security Solution] Remove the word "custom" from bulk action modals #204313

merged 6 commits into from
Dec 18, 2024
+25 −39

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented Dec 14, 2024 •
edited by kibanamachine
Loading

Resolves: #203149

Summary

This PR updates the bulk action modal dialogs by removing the term "custom." With prebuilt rules now being editable, the use of the word "custom" is no longer accurate or appropriate.

Screenshots

Before
Scherm­afbeelding 2024-12-14 om 12 09 58

After
Scherm­afbeelding 2024-12-14 om 11 56 04

Work started on 14-Dec-2024

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels v8.18.0 v8.17.1 labels Dec 14, 2024
@nikitaindik nikitaindik self-assigned this Dec 14, 2024
@nikitaindik nikitaindik marked this pull request as ready for review December 14, 2024 11:23
@nikitaindik nikitaindik requested a review from a team as a code owner December 14, 2024 11:23
@nikitaindik nikitaindik requested a review from maximpn December 14, 2024 11:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik nikitaindik mentioned this pull request Dec 14, 2024
Closed
maximpn
maximpn approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitaindik The diff looks good 👍 Thanks for renaming function params as well 🙏 Tested the PR locally and it works as expected.

@nikitaindik nikitaindik enabled auto-merge (squash) December 16, 2024 09:28
@nikitaindik nikitaindik disabled auto-merge December 16, 2024 11:42
@nikitaindik nikitaindik enabled auto-merge (squash) December 18, 2024 09:00
@nikitaindik nikitaindik merged commit 65bc6bc into elastic:main Dec 18, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12390717928

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/cases_api_integration/security_and_spaces/config_trial.ts / cases security and spaces enabled: trial get_connectors push needsToBePushed sets needs to push to false when the status of a case was changed after the last push

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 22.2MB 22.2MB -649.0B

History

cc @nikitaindik

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
@nikitaindik
[Security Solution] Remove the word "custom" from bulk action modals (e…
ae4a2f9 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024

(cherry picked from commit 65bc6bc)
@kibanamachine kibanamachine mentioned this pull request Dec 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- [Security Solution] Remove warning for rule filter (#201776)
- includes liberation fonts in dockerfile (#204368)
- Fix share modal copy embed code (#204584)
- [ML] Transforms: Support wildcards in the alerting rule flyout (#204226)
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 204313

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @nikitaindik
[8.x] [Security Solution] Remove the word &quot;custom&quot; from bul…
9d6cc07 
…k action modals (#204313) (#204708)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Remove the word &quot;custom&quot; from bulk
action modals (#204313)](#204313)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nikita
Indik","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T10:07:16Z","message":"[Security
Solution] Remove the word \"custom\" from bulk action modals
(#204313)\n\n**Resolves:
https://github.com/elastic/kibana/issues/203149**\n\n## Summary\n\nThis
PR updates the bulk action modal dialogs by removing the
term\n\"custom.\" With prebuilt rules now being editable, the use of the
word\n\"custom\" is no longer accurate or appropriate.\n\n##
Screenshots\n**Before**\n<img width=\"805\" alt=\"Scherm­afbeelding
2024-12-14 om 12 09
58\"\nsrc=\"https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2\"\n/>\n\n**After**\n<img
width=\"728\" alt=\"Scherm­afbeelding 2024-12-14 om 11 56
04\"\nsrc=\"https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a\"\n/>\n\nWork
started on
14-Dec-2024","sha":"65bc6bc2e68256b3dc768d3ad914b6659fb53fb2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v8.17.1"],"title":"[Security
Solution] Remove the word \"custom\" from bulk action
modals","number":204313,"url":"https://github.com/elastic/kibana/pull/204313","mergeCommit":{"message":"[Security
Solution] Remove the word \"custom\" from bulk action modals
(#204313)\n\n**Resolves:
https://github.com/elastic/kibana/issues/203149**\n\n## Summary\n\nThis
PR updates the bulk action modal dialogs by removing the
term\n\"custom.\" With prebuilt rules now being editable, the use of the
word\n\"custom\" is no longer accurate or appropriate.\n\n##
Screenshots\n**Before**\n<img width=\"805\" alt=\"Scherm­afbeelding
2024-12-14 om 12 09
58\"\nsrc=\"https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2\"\n/>\n\n**After**\n<img
width=\"728\" alt=\"Scherm­afbeelding 2024-12-14 om 11 56
04\"\nsrc=\"https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a\"\n/>\n\nWork
started on
14-Dec-2024","sha":"65bc6bc2e68256b3dc768d3ad914b6659fb53fb2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204313","number":204313,"mergeCommit":{"message":"[Security
Solution] Remove the word \"custom\" from bulk action modals
(#204313)\n\n**Resolves:
https://github.com/elastic/kibana/issues/203149**\n\n## Summary\n\nThis
PR updates the bulk action modal dialogs by removing the
term\n\"custom.\" With prebuilt rules now being editable, the use of the
word\n\"custom\" is no longer accurate or appropriate.\n\n##
Screenshots\n**Before**\n<img width=\"805\" alt=\"Scherm­afbeelding
2024-12-14 om 12 09
58\"\nsrc=\"https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2\"\n/>\n\n**After**\n<img
width=\"728\" alt=\"Scherm­afbeelding 2024-12-14 om 11 56
04\"\nsrc=\"https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a\"\n/>\n\nWork
started on
14-Dec-2024","sha":"65bc6bc2e68256b3dc768d3ad914b6659fb53fb2"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nikita Indik <[email protected]>
@nikitaindik
Copy link
Contributor Author

Removed v8.17 target branch for this PR, since these changes are not needed in v8.17.* versions.

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nikitaindik @JoseLuisGJ
[Security Solution] Remove the word "custom" from bulk action modals (e…
77d1d1b 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@nikitaindik @benakansara
[Security Solution] Remove the word "custom" from bulk action modals (e…
82a4dff 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@nikitaindik @CAWilson94
[Security Solution] Remove the word "custom" from bulk action modals (e…
892fb36 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nikitaindik @viduni94
[Security Solution] Remove the word "custom" from bulk action modals (e…
0e41b7a 
…lastic#204313)

**Resolves: elastic#203149

## Summary

This PR updates the bulk action modal dialogs by removing the term
"custom." With prebuilt rules now being editable, the use of the word
"custom" is no longer accurate or appropriate.

## Screenshots
**Before**
<img width="805" alt="Scherm­afbeelding 2024-12-14 om 12 09 58"
src="https://github.com/user-attachments/assets/b354ee44-d565-486f-94d6-6851e9d6a7b2"
/>

**After**
<img width="728" alt="Scherm­afbeelding 2024-12-14 om 11 56 04"
src="https://github.com/user-attachments/assets/c9de12c3-8aca-4ee2-828c-71b05f3b451a"
/>

Work started on 14-Dec-2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@nikitaindik nikitaindik

Labels
backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Bulk action confirmation dialog should not mention "custom" rules
4 participants
@nikitaindik @elasticmachine @kibanamachine @maximpn