[embeddable] remove setCustomEmbeddableFactoryProvider from setup API #203853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Dec 11, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
Unreferenced deprecated APIs
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#203853) Part of elastic#167429 Remove `setCustomEmbeddableFactoryProvider` from embeddable setup API. `setCustomEmbeddableFactoryProvider` only used in `embeddable_enhanced` plugin. Replaced with `initializeReactEmbeddableDynamicActions` in react embeddable system. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 7218d01)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
…up API (#203853) (#204073) # Backport This will backport the following commits from `main` to `8.x`: - [[embeddable] remove setCustomEmbeddableFactoryProvider from setup API (#203853)](#203853) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T16:11:48Z","message":"[embeddable] remove setCustomEmbeddableFactoryProvider from setup API (#203853)\n\nPart of https://github.com/elastic/kibana/issues/167429\r\n\r\nRemove `setCustomEmbeddableFactoryProvider` from embeddable setup API.\r\n`setCustomEmbeddableFactoryProvider` only used in `embeddable_enhanced`\r\nplugin. Replaced with `initializeReactEmbeddableDynamicActions` in react\r\nembeddable system.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7218d01aa42eba6df050262a0c246922d2a0df9d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[embeddable] remove setCustomEmbeddableFactoryProvider from setup API","number":203853,"url":"https://github.com/elastic/kibana/pull/203853","mergeCommit":{"message":"[embeddable] remove setCustomEmbeddableFactoryProvider from setup API (#203853)\n\nPart of https://github.com/elastic/kibana/issues/167429\r\n\r\nRemove `setCustomEmbeddableFactoryProvider` from embeddable setup API.\r\n`setCustomEmbeddableFactoryProvider` only used in `embeddable_enhanced`\r\nplugin. Replaced with `initializeReactEmbeddableDynamicActions` in react\r\nembeddable system.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7218d01aa42eba6df050262a0c246922d2a0df9d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203853","number":203853,"mergeCommit":{"message":"[embeddable] remove setCustomEmbeddableFactoryProvider from setup API (#203853)\n\nPart of https://github.com/elastic/kibana/issues/167429\r\n\r\nRemove `setCustomEmbeddableFactoryProvider` from embeddable setup API.\r\n`setCustomEmbeddableFactoryProvider` only used in `embeddable_enhanced`\r\nplugin. Replaced with `initializeReactEmbeddableDynamicActions` in react\r\nembeddable system.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7218d01aa42eba6df050262a0c246922d2a0df9d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…elastic#203853) Part of elastic#167429 Remove `setCustomEmbeddableFactoryProvider` from embeddable setup API. `setCustomEmbeddableFactoryProvider` only used in `embeddable_enhanced` plugin. Replaced with `initializeReactEmbeddableDynamicActions` in react embeddable system. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #167429
Remove
setCustomEmbeddableFactoryProviderfrom embeddable setup API.setCustomEmbeddableFactoryProvideronly used inembeddable_enhancedplugin. Replaced withinitializeReactEmbeddableDynamicActionsin react embeddable system.