Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [embeddable] remove setCustomEmbeddableFactoryProvider from setup API (#203853) #204073

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…elastic#203853)

Part of elastic#167429

Remove `setCustomEmbeddableFactoryProvider` from embeddable setup API.
`setCustomEmbeddableFactoryProvider` only used in `embeddable_enhanced`
plugin. Replaced with `initializeReactEmbeddableDynamicActions` in react
embeddable system.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 7218d01)
@kibanamachine kibanamachine merged commit 0cf814f into elastic:8.x Dec 12, 2024
13 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddableEnhanced 46 44 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 457 455 -2
embeddableEnhanced 19 15 -4
total -6

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 9 8 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 67.6KB 67.2KB -419.0B
embeddableEnhanced 9.0KB 7.2KB -1.8KB
total -2.2KB
Unknown metric groups

API count

id before after diff
embeddable 562 560 -2
embeddableEnhanced 19 15 -4
total -6

ESLint disabled line counts

id before after diff
embeddableEnhanced 2 1 -1

References to deprecated APIs

id before after diff
embeddableEnhanced 4 0 -4

Total ESLint disabled count

id before after diff
embeddableEnhanced 4 3 -1

Unreferenced deprecated APIs

id before after diff
embeddable 3 4 +1
embeddableEnhanced 1 0 -1
total -0

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants