Fixes for storybook aliases #204842
Merged
Fixes for storybook aliases #204842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smith
commented
Dec 18, 2024
•
smith
commented
- Remove duplicates
- Import list of aliases to buildkite script so we don't need it in two places
- Mention packages as well as plugins in README, and use newer example storybook syntax
- Add mjs support to unbreak slo stories
* Remove duplicates * Import list of aliases to buildkite script so we don't need it in two places * Mention packages as well as plugins in README, and use newer example storybook syntax
smith
added
backport:prev-major
Ikuni17
reviewed
Dec 19, 2024
💚 Build Succeeded
Metrics [docs]
History
|
Ikuni17
approved these changes
Dec 26, 2024
|
Starting backport for target branches: 8.16, 8.17, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Dec 27, 2024
smith
added a commit
to smith/kibana
that referenced
this pull request
Dec 27, 2024
* Remove duplicates * Import list of aliases to buildkite script so we don't need it in two places * Mention packages as well as plugins in README, and use newer example storybook syntax * Add mjs support to unbreak slo stories (cherry picked from commit ddcf076) # Conflicts: # .buildkite/scripts/steps/storybooks/build_and_upload.ts # src/dev/storybook/aliases.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
smith
added a commit
to smith/kibana
that referenced
this pull request
Dec 27, 2024
* Remove duplicates * Import list of aliases to buildkite script so we don't need it in two places * Mention packages as well as plugins in README, and use newer example storybook syntax * Add mjs support to unbreak slo stories (cherry picked from commit ddcf076)
smith
added a commit
to smith/kibana
that referenced
this pull request
Dec 27, 2024
* Remove duplicates * Import list of aliases to buildkite script so we don't need it in two places * Mention packages as well as plugins in README, and use newer example storybook syntax * Add mjs support to unbreak slo stories (cherry picked from commit ddcf076) # Conflicts: # .buildkite/scripts/steps/storybooks/build_and_upload.ts # src/dev/storybook/aliases.ts
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
smith
added a commit
that referenced
this pull request
Dec 30, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fixes for storybook aliases (#204842)](#204842) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan L Smith","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-26T16:38:22Z","message":"Fixes for storybook aliases (#204842)\n\n* Remove duplicates\r\n* Import list of aliases to buildkite script so we don't need it in two\r\nplaces\r\n* Mention packages as well as plugins in README, and use newer example\r\nstorybook syntax\r\n* Add mjs support to unbreak slo stories","sha":"ddcf076ff400315a66e6076d694b301cf7d84070","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:build-storybooks"],"number":204842,"url":"https://github.com/elastic/kibana/pull/204842","mergeCommit":{"message":"Fixes for storybook aliases (#204842)\n\n* Remove duplicates\r\n* Import list of aliases to buildkite script so we don't need it in two\r\nplaces\r\n* Mention packages as well as plugins in README, and use newer example\r\nstorybook syntax\r\n* Add mjs support to unbreak slo stories","sha":"ddcf076ff400315a66e6076d694b301cf7d84070"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204842","number":204842,"mergeCommit":{"message":"Fixes for storybook aliases (#204842)\n\n* Remove duplicates\r\n* Import list of aliases to buildkite script so we don't need it in two\r\nplaces\r\n* Mention packages as well as plugins in README, and use newer example\r\nstorybook syntax\r\n* Add mjs support to unbreak slo stories","sha":"ddcf076ff400315a66e6076d694b301cf7d84070"}}]}] BACKPORT-->
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
* Remove duplicates * Import list of aliases to buildkite script so we don't need it in two places * Mention packages as well as plugins in README, and use newer example storybook syntax * Add mjs support to unbreak slo stories
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
* Remove duplicates * Import list of aliases to buildkite script so we don't need it in two places * Mention packages as well as plugins in README, and use newer example storybook syntax * Add mjs support to unbreak slo stories
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.