Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] Fixes for storybook aliases (#204842) #205205

Open
wants to merge 6 commits into
base: 8.17
Choose a base branch
from
Open

[8.17] Fixes for storybook aliases (#204842) #205205

wants to merge 6 commits into from
+34 −65

Conversation

smith
Copy link
Contributor

@smith smith commented Dec 27, 2024

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

@smith
Fixes for storybook aliases (elastic#204842)
04cef7c 
* Remove duplicates
* Import list of aliases to buildkite script so we don't need it in two
places
* Mention packages as well as plugins in README, and use newer example
storybook syntax
* Add mjs support to unbreak slo stories

(cherry picked from commit ddcf076)

# Conflicts:
#	.buildkite/scripts/steps/storybooks/build_and_upload.ts
#	src/dev/storybook/aliases.ts
@smith smith requested a review from kibanamachine as a code owner December 27, 2024 13:37
@smith smith added the backport label Dec 27, 2024
@smith smith enabled auto-merge (squash) December 27, 2024 13:37
@smith smith mentioned this pull request Dec 27, 2024
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 3, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Policy Advanced Settings section should expand and collapse section when button is clicked

Metrics [docs]

✅ unchanged

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport ci:build-storybooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith @elasticmachine @Ikuni17 @kibanamachine