Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Dosant · 2024-12-19T14:33:27Z

Summary

Part of #203163

Relocating only shared-ux-owned plugins for now . Tip on how to review changes if GitHub UI is unmanageable - https://elastic.slack.com/archives/C07TCKTA22E/p1734606026689389

node scripts/relocate.js --include "@kbn/advanced-settings-plugin" --include "@kbn/banners-plugin" --include "@kbn/content-management-plugin" --include "@kbn/custom-branding-plugin" --include "@kbn/files-management-plugin" --include "@kbn/files-plugin" --include "@kbn/global-search-bar-plugin" --include "@kbn/global-search-plugin" --include "@kbn/global-search-providers-plugin" --include "@kbn/guided-onboarding-plugin" --include "@kbn/home-plugin" --include "@kbn/image-embeddable-plugin" --include "@kbn/kibana-overview-plugin" --include "@kbn/kibana-react-plugin" --include "@kbn/kibana-utils-plugin" --include "@kbn/navigation-plugin" --include "@kbn/no-data-page-plugin" --include "@kbn/notifications-plugin" --include "@kbn/reporting-plugin" --include "@kbn/saved-objects-plugin" --include "@kbn/saved-objects-tagging-oss-plugin" --include "@kbn/saved-objects-tagging-plugin" --include "@kbn/screenshot-mode-plugin" --include "@kbn/serverless" --include "@kbn/share-plugin" --include --include "@kbn/ui-actions-enhanced-plugin" --include "@kbn/ui-actions-plugin"

  ┌─────────────────────────────────────────┬───────────────────────────────────────────────────────────┐
  │  Id                                     │  Target folder                                            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/content-management-plugin         │  src/platform/plugins/shared/content_management           │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/custom-branding-plugin            │  x-pack/platform/plugins/private/custom_branding          │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/files-management-plugin           │  src/platform/plugins/private/files_management            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/files-plugin                      │  src/platform/plugins/shared/files                        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-bar-plugin          │  x-pack/platform/plugins/private/global_search_bar        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-plugin              │  x-pack/platform/plugins/shared/global_search             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-providers-plugin    │  x-pack/platform/plugins/private/global_search_providers  │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/guided-onboarding-plugin          │  src/platform/plugins/shared/guided_onboarding            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/home-plugin                       │  src/platform/plugins/shared/home                         │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/image-embeddable-plugin           │  src/platform/plugins/private/image_embeddable            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-overview-plugin            │  src/platform/plugins/private/kibana_overview             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-react-plugin               │  src/platform/plugins/shared/kibana_react                 │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-utils-plugin               │  src/platform/plugins/shared/kibana_utils                 │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/navigation-plugin                 │  src/platform/plugins/shared/navigation                   │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/no-data-page-plugin               │  src/platform/plugins/private/no_data_page                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/notifications-plugin              │  x-pack/platform/plugins/shared/notifications             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/reporting-plugin                  │  x-pack/platform/plugins/private/reporting                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-plugin              │  src/platform/plugins/shared/saved_objects                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-tagging-oss-plugin  │  src/platform/plugins/shared/saved_objects_tagging_oss    │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-tagging-plugin      │  x-pack/platform/plugins/private/saved_objects_tagging    │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/screenshot-mode-plugin            │  src/platform/plugins/shared/screenshot_mode              │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/serverless                        │  x-pack/platform/plugins/shared/serverless                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/share-plugin                      │  src/platform/plugins/shared/share                        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/ui-actions-enhanced-plugin        │  src/platform/plugins/shared/ui_actions_enhanced          │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/ui-actions-plugin                 │  src/platform/plugins/shared/ui_actions                   │
  └─────────────────────────────────────────┴───────────────────────────────────────────────────────────┘

github-actions · 2024-12-19T14:33:42Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

…elocate-20241219135219 # Conflicts: # .buildkite/scripts/pipelines/pull_request/pipeline.ts # .eslintignore # .github/CODEOWNERS # .i18nrc.json # docs/developer/plugin-list.asciidoc # package.json # src/dev/storybook/aliases.ts # src/plugins/telemetry/schema/oss_platform.json # tsconfig.base.json # x-pack/.i18nrc.json # x-pack/platform/plugins/private/canvas/storybook/canvas_webpack.ts # x-pack/plugins/telemetry_collection_xpack/schema/xpack_platform.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json

…elocate-20241219135219 # Conflicts: # .github/CODEOWNERS # .i18nrc.json # package.json # tsconfig.base.json # x-pack/.i18nrc.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json

…elocate-20241219135219 # Conflicts: # .buildkite/scripts/pipelines/pull_request/pipeline.ts # .github/CODEOWNERS # .i18nrc.json # src/plugins/telemetry/schema/oss_platform.json # src/plugins/telemetry/schema/oss_plugins.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json

…elocate-20241219135219

…sant/kibana into kbn-team-1309-relocate-20241219135219

Dosant · 2025-01-02T19:16:46Z

@elasticmachine merge upstream

elasticmachine · 2025-01-02T19:16:49Z

merge conflict between base and head

…elocate-20241219135219

kibanamachine · 2025-01-03T11:39:19Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12597145645

elasticmachine · 2025-01-03T11:39:53Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #71

Test Failures

[job] [logs] FTR Configs #71 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM AWS CIS_AWS Organization Cloud Formation Clicking on Launch CloudFormation on post intall modal should lead user to Cloud Formation page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`kibanaReact`	197.1KB	197.1KB	-12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	37.3KB	36.9KB	-410.0B

History

💚 Build #263683 succeeded 1d8aead
💔 Build #263651 failed f4e9570
💛 Build #263497 was flaky 5c8e1a5
💚 Build #263289 succeeded 2d17091
💛 Build #263127 was flaky b124438
💛 Build #262858 was flaky fad8a41

kibanamachine · 2025-01-03T11:44:23Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204959

Questions ?

Please refer to the Backport tool documentation

Dosant · 2025-01-03T15:31:11Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…x-sharedux` (elastic#204959) ## Summary Part of elastic#203163 Relocating only shared-ux-owned plugins for now (cherry picked from commit 9215df9) # Conflicts: # .github/CODEOWNERS # .i18nrc.json # docs/developer/plugin-list.asciidoc # package.json # src/platform/plugins/shared/saved_objects/tsconfig.json # x-pack/.gitignore # x-pack/.i18nrc.json # x-pack/platform/plugins/private/reporting/.gitignore # x-pack/platform/plugins/private/reporting/server/config/index.test.ts # x-pack/platform/plugins/private/reporting/server/deprecations/__snapshots__/reporting_role.test.ts.snap # x-pack/platform/plugins/private/reporting/server/deprecations/reporting_role.test.ts # x-pack/platform/plugins/private/reporting/server/deprecations/reporting_role.ts # x-pack/platform/plugins/private/reporting/server/routes/internal/generate/csv_searchsource_immediate.ts

Dosant added 25 commits December 19, 2024 14:54

Relocating module @kbn/content-management-plugin

3c34745

Relocating module @kbn/custom-branding-plugin

f9a24a5

Relocating module @kbn/files-management-plugin

9c66dc1

Relocating module @kbn/files-plugin

502f6e9

Relocating module @kbn/global-search-bar-plugin

b6fbaae

Relocating module @kbn/global-search-plugin

25687eb

Relocating module @kbn/global-search-providers-plugin

72bc3ab

Relocating module @kbn/guided-onboarding-plugin

82904c4

Relocating module @kbn/home-plugin

0e789d4

Relocating module @kbn/image-embeddable-plugin

113e536

Relocating module @kbn/kibana-overview-plugin

d565add

Relocating module @kbn/kibana-react-plugin

2d75db9

Relocating module @kbn/kibana-utils-plugin

72c936e

Relocating module @kbn/navigation-plugin

1f3b4de

Relocating module @kbn/no-data-page-plugin

adcff47

Relocating module @kbn/notifications-plugin

df2e448

Relocating module @kbn/reporting-plugin

a64deb7

Relocating module @kbn/saved-objects-plugin

7fac4cd

Relocating module @kbn/saved-objects-tagging-oss-plugin

e9c2c94

Relocating module @kbn/saved-objects-tagging-plugin

7be74c3

Relocating module @kbn/screenshot-mode-plugin

87a16af

Relocating module @kbn/serverless

5e42148

Relocating module @kbn/share-plugin

bd9a8ff

Relocating module @kbn/ui-actions-enhanced-plugin

cbc98ce

Relocating module @kbn/ui-actions-plugin

6620fe5

Dosant changed the title ~~Kbn team 1309 relocate 20241219135219~~ Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux Dec 19, 2024

Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024

Dosant and others added 14 commits December 27, 2024 12:34

fix codeowners

cac022e

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

c5098df

[CI] Auto-commit changed files from 'node scripts/telemetry_check'

b124438

Merge branch 'main' of github.com:elastic/kibana into kbn-team-1309-r…

4631c0e

…elocate-20241219135219 # Conflicts: # .github/CODEOWNERS # .i18nrc.json # package.json # tsconfig.base.json # x-pack/.i18nrc.json # x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json

post merge fix

2d17091

post merge

5c8e1a5

Merge branch 'main' of github.com:elastic/kibana into kbn-team-1309-r…

b285299

…elocate-20241219135219

Relocating module @kbn/advanced-settings-plugin

368a6bb

Relocating module @kbn/banners-plugin

27e56ba

Merge branch 'kbn-team-1309-relocate-20241219135219' of github.com:Do…

f673b1e

…sant/kibana into kbn-team-1309-relocate-20241219135219

codeowners

f4e9570

fix prettier

1d8aead

Dosant mentioned this pull request Jan 2, 2025

Sustainable Kibana Architecture: Move modules owned by @elastic/appex-sharedux #205405

Open

3 tasks

MichaelMarcialis approved these changes Jan 2, 2025

View reviewed changes

Dosant removed the request for review from ashokaditya January 2, 2025 16:21

eokoneyo approved these changes Jan 2, 2025

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into kbn-team-1309-r…

2d186ff

…elocate-20241219135219

Dosant enabled auto-merge (squash) January 3, 2025 11:37

Dosant merged commit 9215df9 into elastic:main Jan 3, 2025
9 checks passed

kibanamachine added the v9.0.0 label Jan 3, 2025

Dosant mentioned this pull request Jan 3, 2025

[8.x] Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux (#204959) #205508

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Dosant commented Dec 19, 2024 •

edited by kibanamachine

Loading

github-actions bot commented Dec 19, 2024

Dosant commented Jan 2, 2025

elasticmachine commented Jan 2, 2025

kibanamachine commented Jan 3, 2025

elasticmachine commented Jan 3, 2025

kibanamachine commented Jan 3, 2025

Dosant commented Jan 3, 2025

Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux #204959

Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux #204959

Conversation

Dosant commented Dec 19, 2024 • edited by kibanamachine Loading

Summary

github-actions bot commented Dec 19, 2024

Dosant commented Jan 2, 2025

elasticmachine commented Jan 2, 2025

kibanamachine commented Jan 3, 2025

elasticmachine commented Jan 3, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Jan 3, 2025

💔 All backports failed

Manual backport

Questions ?

Dosant commented Jan 3, 2025

💚 All backports created successfully

Questions ?

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Dosant commented Dec 19, 2024 •

edited by kibanamachine

Loading