Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux (#204959) #205508

Merged
merged 10 commits into from
Jan 5, 2025

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jan 3, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…x-sharedux` (elastic#204959)

## Summary

Part of elastic#203163

Relocating only shared-ux-owned plugins for now

(cherry picked from commit 9215df9)

# Conflicts:
#	.github/CODEOWNERS
#	.i18nrc.json
#	docs/developer/plugin-list.asciidoc
#	package.json
#	src/platform/plugins/shared/saved_objects/tsconfig.json
#	x-pack/.gitignore
#	x-pack/.i18nrc.json
#	x-pack/platform/plugins/private/reporting/.gitignore
#	x-pack/platform/plugins/private/reporting/server/config/index.test.ts
#	x-pack/platform/plugins/private/reporting/server/deprecations/__snapshots__/reporting_role.test.ts.snap
#	x-pack/platform/plugins/private/reporting/server/deprecations/reporting_role.test.ts
#	x-pack/platform/plugins/private/reporting/server/deprecations/reporting_role.ts
#	x-pack/platform/plugins/private/reporting/server/routes/internal/generate/csv_searchsource_immediate.ts
Copy link
Contributor

github-actions bot commented Jan 3, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Looks very similar to the diff of 9215df9

@tsullivan tsullivan self-requested a review January 3, 2025 19:31
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs: Dosant#14

@Dosant Dosant requested a review from tsullivan January 5, 2025 12:06
@Dosant Dosant merged commit d58b812 into elastic:8.x Jan 5, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 197.1KB 197.1KB -12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 37.3KB 36.9KB -410.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants