Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX Plugin, Exploratory View] Audit new EUI Borealis theme #205051

Closed
4 of 9 tasks
jasonrhodes opened this issue Dec 20, 2024 · 1 comment · Fixed by #205195 or #205212
Closed
4 of 9 tasks

[UX Plugin, Exploratory View] Audit new EUI Borealis theme #205051

jasonrhodes opened this issue Dec 20, 2024 · 1 comment · Fixed by #205195 or #205212
Assignees
@fkanout
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Dec 20, 2024 •
edited by fkanout
Loading

Full instructions for how to do this audit can be found #199715, but the AC checklist has been copied here, with links to the relevant sections of that issue.

Acceptance criteria for the UX plugin and the Exploratory View plugin

Please break this into two issues and PRs if that's easier, so long as we cover both plugins with our best effort.

Important

Things marked as Required must be completed. Everything else we would really like teams to give their best effort to resolve, but are ultimately non-blocking.

Important details on each of these steps is noted in the main issue which has been linked to via each step's "details" link, but these "details" links reference HTML anchors in the linked issue and may require reloading the page in order to have the browser navigate correctly to the anchor position.

  • (Required) All usages of "success" colors have been updated to "accentSecondary" and "textAccentSecondary" as needed (details).
  • (Required) All usages of "successText" colors have been updated to "textAccentSecondary" as needed (details).
  • (Required) All references to renamed tokens have been updated to use the new token name. (details)
  • (Required) All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. (details)

Warning

Please be careful when removing styled components / moving to Emotion. These changes require tooling changes that can produce major problems in Kibana. If you do remove styled components from any files, they should be individually removed from the styled_components_files.js registry file, but please check the status of this PR to see whether there is a script to be run to generate that file from all of the current places where style components are imported in Kibana.

Follow up tasks to be completed later

These were originally part of the AC of this issue, but have since been de-scoped. I leave them here for future reference.

  • @kkurstak or @patpscal has reviewed the UI with the new changes and is ready to ship.
  • All usages of vis colors for non-visulalization usage have been removed in favor of other EUI color tokens, where possible. (details)
  • All "Custom colors" have been replaced with EUI color tokens. (details)
  • All usages of color functions have been removed in favor of color tokens, where possible. (details)
  • All usages of JSON tokens have been removed in favor of color tokens, where possible. (details)
@jasonrhodes jasonrhodes added the Team:obs-ux-management Observability Management User Experience Team label Dec 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@fkanout fkanout self-assigned this Dec 24, 2024
This was referenced Dec 27, 2024
Merged
Merged
fkanout added a commit that referenced this issue Jan 14, 2025
@fkanout
[UX Plugin] Audit new EUI Borealis theme (#205195)
ac58415 
## Summary

It fixes #205051

---------
fkanout added a commit that referenced this issue Jan 15, 2025
@fkanout
[Exploratory View] Audit new EUI Borealis theme (#205212)
b0973cf 
## Summary

It fixes #205051 

<del>
Files are excluded because of `euiScrollBar` and `euiScrollBarCorner`
replacement (TBD)
-
x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/series_editor.tsx

-
x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/components/filter_values_list.tsx
</del>
✅  DONE
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@fkanout @viduni94
[UX Plugin] Audit new EUI Borealis theme (elastic#205195)
b25e719 
## Summary

It fixes elastic#205051

---------
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@fkanout @viduni94
[Exploratory View] Audit new EUI Borealis theme (elastic#205212)
f67a7f4 
## Summary

It fixes elastic#205051 

<del>
Files are excluded because of `euiScrollBar` and `euiScrollBarCorner`
replacement (TBD)
-
x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/series_editor.tsx

-
x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/components/filter_values_list.tsx
</del>
✅  DONE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkanout fkanout

Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@jasonrhodes @fkanout @elasticmachine