Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX Plugin] Audit new EUI Borealis theme #205195

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[UX Plugin] Audit new EUI Borealis theme #205195

wants to merge 10 commits into from

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented Dec 27, 2024

Summary

It fixes #205051

@fkanout fkanout self-assigned this Dec 27, 2024
@fkanout fkanout added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-management Observability Management User Experience Team EUI Visual Refresh labels Dec 27, 2024
@fkanout fkanout changed the title [UX Plugin, Exploratory View] Audit new EUI Borealis theme [UX Plugin] Audit new EUI Borealis theme Dec 27, 2024
@fkanout fkanout marked this pull request as ready for review December 27, 2024 12:00
@fkanout fkanout requested a review from a team as a code owner December 27, 2024 12:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@fkanout fkanout requested review from kkurstak and patpscal December 27, 2024 12:01
@fkanout fkanout requested a review from a team as a code owner December 27, 2024 16:37
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 27, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 207 223 +16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 168.2KB 178.8KB +10.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ux 7.0KB 6.9KB -114.0B

History

cc @fkanout

jbudz
jbudz approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-babel-preset/styled_components_files.js LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@kkurstak kkurstak Awaiting requested review from kkurstak

@patpscal patpscal Awaiting requested review from patpscal

At least 1 approving review is required to merge this pull request.

Assignees

@fkanout fkanout

Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX Plugin, Exploratory View] Audit new EUI Borealis theme
3 participants
@fkanout @elasticmachine @jbudz