implements backoff delay in usage counters service #206363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7701[✅] test/plugin_functional/config.ts: 25/25 tests passed. |
afharo
reviewed
Jan 11, 2025
...latform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.test.ts
Outdated
Show resolved
Hide resolved
...latform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.test.ts
Show resolved
Hide resolved
src/platform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7715[✅] test/plugin_functional/config.ts: 50/50 tests passed. |
afharo
reviewed
Jan 14, 2025
src/platform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
TinaHeiligers
commented
Jan 15, 2025
TinaHeiligers
commented
Jan 15, 2025
| kibana: { | ||
| usageCounters: { | ||
| results: [mockError, 'pass'], | ||
| // requires extended test runtime because of exponential backoff delay for retries |
There was a problem hiding this comment.
For our future selves, to remind us why this specific test is allowed to run longer than 5s.
TinaHeiligers
commented
Jan 15, 2025
src/platform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.ts
Outdated
Show resolved
Hide resolved
...latform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.test.ts
Show resolved
Hide resolved
fix comment
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 15, 2025
fix elastic#192829 ## Summary Usage counters lose counts when there's a version conflict exception to increment counters. ATM, the service retries `incrementCounter` immediately on error, which could also fail if another Kibana tries at the same time. Using a backoff retry reduces the likelihood of a version conflict exception. This PR replaces the retry with an exponential `backoffDelay` that will wait longer between retry attempts. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701) --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit fd3b4ed)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 15, 2025
fix elastic#192829 ## Summary Usage counters lose counts when there's a version conflict exception to increment counters. ATM, the service retries `incrementCounter` immediately on error, which could also fail if another Kibana tries at the same time. Using a backoff retry reduces the likelihood of a version conflict exception. This PR replaces the retry with an exponential `backoffDelay` that will wait longer between retry attempts. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701) --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit fd3b4ed)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 15, 2025
fix elastic#192829 ## Summary Usage counters lose counts when there's a version conflict exception to increment counters. ATM, the service retries `incrementCounter` immediately on error, which could also fail if another Kibana tries at the same time. Using a backoff retry reduces the likelihood of a version conflict exception. This PR replaces the retry with an exponential `backoffDelay` that will wait longer between retry attempts. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701) --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit fd3b4ed)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
backport to 7.17 not needed. |
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2025
…206852) # Backport This will backport the following commits from `main` to `8.x`: - [implements backoff delay in usage counters service (#206363)](#206363) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T18:42:44Z","message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open"],"title":"implements backoff delay in usage counters service","number":206363,"url":"https://github.com/elastic/kibana/pull/206363","mergeCommit":{"message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206363","number":206363,"mergeCommit":{"message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2025
…206851) # Backport This will backport the following commits from `main` to `8.17`: - [implements backoff delay in usage counters service (#206363)](#206363) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T18:42:44Z","message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open"],"title":"implements backoff delay in usage counters service","number":206363,"url":"https://github.com/elastic/kibana/pull/206363","mergeCommit":{"message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206363","number":206363,"mergeCommit":{"message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2025
…206850) # Backport This will backport the following commits from `main` to `8.16`: - [implements backoff delay in usage counters service (#206363)](#206363) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T18:42:44Z","message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open"],"title":"implements backoff delay in usage counters service","number":206363,"url":"https://github.com/elastic/kibana/pull/206363","mergeCommit":{"message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206363","number":206363,"mergeCommit":{"message":"implements backoff delay in usage counters service (#206363)\n\nfix https://github.com/elastic/kibana/issues/192829\r\n\r\n## Summary\r\n\r\nUsage counters lose counts when there's a version conflict exception to\r\nincrement counters.\r\nATM, the service retries `incrementCounter` immediately on error, which\r\ncould also fail if another Kibana tries at the same time.\r\nUsing a backoff retry reduces the likelihood of a version conflict\r\nexception. \r\n\r\nThis PR replaces the retry with an exponential `backoffDelay` that will\r\nwait longer between retry attempts.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"fd3b4ed590006212855c1a80994649eacbf41f31"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
fix elastic#192829 ## Summary Usage counters lose counts when there's a version conflict exception to increment counters. ATM, the service retries `incrementCounter` immediately on error, which could also fail if another Kibana tries at the same time. Using a backoff retry reduces the likelihood of a version conflict exception. This PR replaces the retry with an exponential `backoffDelay` that will wait longer between retry attempts. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7701) --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #192829
Summary
Usage counters lose counts when there's a version conflict exception to increment counters.
ATM, the service retries
incrementCounterimmediately on error, which could also fail if another Kibana tries at the same time.Using a backoff retry reduces the likelihood of a version conflict exception.
This PR replaces the retry with an exponential
backoffDelaythat will wait longer between retry attempts.