Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements backoff delay in usage counters service #206363

Merged
merged 12 commits into from
Jan 15, 2025
Merged

implements backoff delay in usage counters service #206363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b912e64
implements backoff delay in usage counters service
TinaHeiligers Jan 10, 2025
963bfe5
Adds dev comment
TinaHeiligers Jan 10, 2025
cf984ae
Merge branch 'main' into kbn192829/usage-counters-backoff-retry
elasticmachine Jan 12, 2025
44724bb
assert both warning logs
TinaHeiligers Jan 13, 2025
8093282
Retry more than once to assert behavior
TinaHeiligers Jan 13, 2025
bd691be
retry more than once to verify backoff behavior
TinaHeiligers Jan 13, 2025
d970e88
change backoffDelay to private usage counter service method
TinaHeiligers Jan 13, 2025
d619f65
increase backoff delay and default retry count
TinaHeiligers Jan 15, 2025
4411951
backoff delay as exported const
TinaHeiligers Jan 15, 2025
106dcb1
dev comment for extended test runtime
TinaHeiligers Jan 15, 2025
334162d
Merge branch 'main' into kbn192829/usage-counters-backoff-retry
elasticmachine Jan 15, 2025
e7edc62
Apply suggestions from code review
TinaHeiligers Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
backoff delay as exported const
  • Loading branch information
@TinaHeiligers
TinaHeiligers committed Jan 15, 2025
commit 4411951f571bc22629ed8160b2f979ac3e633bc0
1 change: 1 addition & 0 deletions src/platform/plugins/shared/usage_collection/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
export const KIBANA_STATS_TYPE = 'kibana_stats';
export const DEFAULT_MAXIMUM_WAIT_TIME_FOR_ALL_COLLECTORS_IN_S = 1;
export const MAIN_APP_DEFAULT_VIEW_ID = 'main';
export const USAGE_COUNTERS_BACKOFF_DELAY_IN_MS = 50;
4 changes: 3 additions & 1 deletion src/platform/plugins/shared/usage_collection/server/usage_counters/usage_counters_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {
} from './saved_objects';
import { registerUsageCountersRollups } from './rollups';
import { searchUsageCounters } from './search';
import { USAGE_COUNTERS_BACKOFF_DELAY_IN_MS } from '../../common/constants';

interface UsageCountersLogMeta extends LogMeta {
kibana: { usageCounters: { results: unknown[] } };
Expand Down Expand Up @@ -159,7 +160,8 @@ export class UsageCountersService {
};
};

private backoffDelay = (attempt: number) => Math.pow(2, attempt) * 50; // exponential backoff: 20ms, 40ms, 80ms, 150ms etc
private backoffDelay = (attempt: number) =>
Math.pow(2, attempt) * USAGE_COUNTERS_BACKOFF_DELAY_IN_MS; // exponential backoff: 50ms, 100ms, 200ms

private storeDate$(
counters: UsageCounters.v1.CounterMetric[],
Expand Down