Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Reorganize UI components #103571

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 28, 2021

Summary

Needed for: #102833

In the previous code, it was difficult to understand the purpose of many of the React components under Reporting. There was a single components folder with files that are used in different places in the UI.

This PR organizes the components based on purpose and where they are in the UI:

  • management: components for the Management UI
  • notifier: components for the job status toast messages
  • panel_actions: Dashboard panel Share menu items for Reporting
  • share_menu: Dashboard panel Share menu items for Reporting
x-pack/plugins/reporting/public
├── index.ts
├── lib
│   ├── job_queue_client.test.mocks.ts
│   ├── license_check.test.ts
│   ├── license_check.ts
│   ├── reporting_api_client.ts
│   ├── __snapshots__
│   │   └── stream_handler.test.ts.snap
│   ├── stream_handler.test.ts
│   └── stream_handler.ts
├── management
│   ├── index.ts
│   ├── mount_management_section.tsx
│   ├── report_delete_button.tsx
│   ├── report_diagnostic.tsx
│   ├── report_download_button.tsx
│   ├── report_error_button.tsx
│   ├── report_info_button.test.tsx
│   ├── report_info_button.tsx
│   ├── report_listing.test.tsx
│   ├── report_listing.tsx
│   └── __snapshots__
│       ├── report_info_button.test.tsx.snap
│       └── report_listing.test.tsx.snap
├── mocks.ts
├── notifier
│   ├── general_error.tsx
│   ├── index.ts
│   ├── job_completion_notifications.ts
│   ├── job_download_button.tsx
│   ├── job_failure.tsx
│   ├── job_success.tsx
│   ├── job_warning_formulas.tsx
│   ├── job_warning_max_size.tsx
│   └── report_link.tsx
├── panel_actions
│   ├── get_csv_panel_action.test.ts
│   └── get_csv_panel_action.tsx
├── plugin.ts
├── share_menu
│   ├── panel_spinner.tsx
│   ├── register_csv_reporting.tsx
│   ├── register_pdf_png_reporting.tsx
│   ├── reporting_panel_content_lazy.tsx
│   ├── reporting_panel_content.test.tsx
│   ├── reporting_panel_content.tsx
│   ├── screen_capture_panel_content_lazy.tsx
│   ├── screen_capture_panel_content.test.tsx
│   ├── screen_capture_panel_content.tsx
│   └── __snapshots__
│       └── screen_capture_panel_content.test.tsx.snap
├── shared
│   ├── get_shared_components.tsx
│   └── index.ts
└── __snapshots__

@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 Team:AppServices labels Jun 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan tsullivan requested a review from a team June 28, 2021 22:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 33.1KB 64.9KB +31.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 85.5KB 54.4KB -31.1KB
Unknown metric groups

async chunk count

id before after diff
reporting 1 3 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

Not asking for review with this, since it only import statements were changed.

@tsullivan tsullivan merged commit aafcc47 into elastic:master Jun 29, 2021
@tsullivan tsullivan deleted the reporting/public-reorg branch June 29, 2021 00:23
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jun 29, 2021
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants