Migrate remaining src/core/**/*.js files to typescript
#117259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
v8.1.0
v8.0.0
chore
technical debt
pgayvallet
force-pushed
the
kbn-117123-migrate-core-js-to-ts
branch
from
51f1967 to
62f2fc3
Compare
pgayvallet
added
the
release_note:skip
pgayvallet
added
the
auto-backport
|
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
rudolf
approved these changes
Nov 8, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2021
) * migrate scoped_client_provider tests * migrate saved_objects_client to ts * fix return values assertions * start fixing violations for repository.test.ts * fix ~750 violations, 201 left * 184 left * 169 left * 150 left * 132 left * fixed `find` violations, 117 left * fixed `removeReferencesTo` violations, 114 left * fixed `delete` violations, 105 left * fixed `create` violations, 93 left * fixed `checkConflicts` violations, 89 left * fixed most `bulkUpdate` violations, 60 left * fixed remaining `bulkUpdate` violations, 54 left * fixed `bulkResolve` violations, 52 left * fixed `bulkGet` violations, 37 left * fixed most `bulkCreate` violations, 14 left * fixed last `bulkCreate` violations, 5 left * Everything but the SOR constructor * ignore warning on SOR private constructor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 9, 2021
…117863) * migrate scoped_client_provider tests * migrate saved_objects_client to ts * fix return values assertions * start fixing violations for repository.test.ts * fix ~750 violations, 201 left * 184 left * 169 left * 150 left * 132 left * fixed `find` violations, 117 left * fixed `removeReferencesTo` violations, 114 left * fixed `delete` violations, 105 left * fixed `create` violations, 93 left * fixed `checkConflicts` violations, 89 left * fixed most `bulkUpdate` violations, 60 left * fixed remaining `bulkUpdate` violations, 54 left * fixed `bulkResolve` violations, 52 left * fixed `bulkGet` violations, 37 left * fixed most `bulkCreate` violations, 14 left * fixed last `bulkCreate` violations, 5 left * Everything but the SOR constructor * ignore warning on SOR private constructor Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #117123
Migrate the following files from js to ts:
src/core/server/saved_objects/service/lib/scoped_client_provider.test.jssrc/core/server/saved_objects/service/saved_objects_client.test.jssrc/core/server/saved_objects/service/lib/repository.test.jswill backport to
8.0to avoid potential backport conflicts of other PRs as this is not impacting any production code.I will create a follow-up issue to split
src/core/server/saved_objects/service/lib/repository.test.jsinto multiple files (one per API)