New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Alerting] A redundant summary alert is shown on rule details alerts list #150088

Merged

doakalexi merged 7 commits into elastic:main from doakalexi:bug/remove-redundant-summary-alert

Feb 8, 2023

Contributor

doakalexi commented Feb 1, 2023 •

edited by kibanamachine

Loading

Resolves #149824

Summary

Added a filter to filter out logs that have an action set to execute-action in the alert_summary route on the rules details
page.
Updated how we log summary alerts by removing the alertId and group fields. I added a new summary field to kibana.alerting that includes the counts for new, ongoing, and recovered alerts.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

To verify

Create a rule that has Alert Summary and let the rule run.
Click on the rule to navigate to the rule details page and look at the Alerts tab. Verify that the summary alert is not listed in the table.

This is a screen shot of the table in the issue:
We want to verify that the last row is no longer there.


          Adding filter for summary alerts in rule details

6c7f44b

doakalexi changed the title ~~Adding filter for summary alerts in rule details~~ [ResponseOps][Alerting] A redundant summary alert is shown on rule details alerts list

doakalexi added Team:ResponseOps bug release_note:skip labels


          Adding new fields to the event log for summary alerts

doakalexi marked this pull request as ready for review

February 7, 2023 13:12

doakalexi requested a review from a team as a code owner

February 7, 2023 13:12

Contributor

elasticmachine commented Feb 7, 2023

Pinging @elastic/response-ops (Team:ResponseOps)


          Merge branch 'main' into bug/remove-redundant-summary-alert

db32d04

ersin-erdal reviewed

View reviewed changes

x-pack/plugins/event_log/generated/schemas.ts Show resolved Hide resolved

doakalexi added the v8.7.0 label

ersin-erdal reviewed

View reviewed changes

x-pack/plugins/alerting/server/rules_client/methods/get_alert_summary.ts Outdated Show resolved Hide resolved

ersin-erdal approved these changes

View reviewed changes

Contributor

ersin-erdal left a comment

LGTM.
Tested locally, works as expected.
Asked a question but if the current filter is ok, it can be ignored.

doakalexi added 2 commits

February 7, 2023 12:37


          Adding provider filter

351bf86


          Merge branch 'bug/remove-redundant-summary-alert' of github.com:doaka…

ada6531

…lexi/kibana into bug/remove-redundant-summary-alert

ymao1 reviewed

View reviewed changes

x-pack/plugins/alerting/server/rules_client/methods/get_alert_summary.ts Outdated Show resolved Hide resolved


          Fixing mistake

301d1e1

ymao1 approved these changes

View reviewed changes

Contributor

ymao1 left a comment

Verified this works as expected. Left some nits about unit tests and also wondering if we have functional tests for the alert summary feature? Seems like this type of change should've triggered some sort of failure in a FT that looks at event log output (which we normally add for new features). If there is not, can we make a followup issue to address the functional testing for summaries?

x-pack/plugins/alerting/server/lib/create_alert_event_log_record_object.ts

                     ? {
                         alerting: {
                           ...(params.instanceId ? { instance_id: params.instanceId } : {}),
                           ...(group ? { action_group_id: group } : {}),
+                          ...(alertSummary

Contributor

ymao1 Feb 7, 2023

nit: maybe a unit test for this?

Contributor Author

doakalexi Feb 7, 2023

Resolved in this commit 4889843

x-pack/plugins/alerting/server/task_runner/execution_handler.ts Show resolved Hide resolved


          Adding tests to for alert summary logs

doakalexi mentioned this pull request

Write an Alert Summary event log functional test #150474

Closed

Collaborator

kibana-ci commented Feb 7, 2023

💚 Build Succeeded

Buildkite Build
Commit: 4889843

Metrics [docs]

✅ unchanged

History

💚 Build #106063 succeeded db32d04
💚 Build #105872 succeeded 9554337
💚 Build #104840 succeeded 6c7f44b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

doakalexi added the v8.8.0 label

doakalexi merged commit 1856323 into elastic:main

Contributor

kibanamachine commented Feb 8, 2023

💔 All backports failed

Status	Branch	Result
❌	8.8	The branch "8.8" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 150088

Questions ?

Please refer to the Backport tool documentation

kibanamachine added the backport missing label

Contributor

kibanamachine commented Dec 11, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

3 similar comments

Contributor

kibanamachine commented Dec 12, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Dec 24, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Dec 25, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Dec 27, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

11 similar comments

Contributor

kibanamachine commented Dec 28, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Dec 30, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Jan 3, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Jan 7, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Jan 8, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Jan 9, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Jan 13, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Jul 13, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Sep 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Sep 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

Contributor

kibanamachine commented Sep 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150088 locally

jbudz added the backport:skip label

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip bug release_note:skip Team:ResponseOps v8.7.0 v8.8.0