[Fleet] Fix output backfill for preconfigured outputs #173088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Looks like there is an edge case not handled in that code it seems there is also a type error in the kibana logs related to that code https://github.com/nchaulet/kibana/blob/523474f7e9030db78445941aa55a46e560d73e97/x-pack/plugins/fleet/common/services/output_helpers.ts#L55
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2023
## Summary Closes elastic#173081 Fixes output backfill for existing preconfigured outputs. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Nicolas Chaulet <[email protected]> (cherry picked from commit 61b413e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2023
#173118) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix output backfill for preconfigured outputs (#173088)](#173088) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T21:16:34Z","message":"[Fleet] Fix output backfill for preconfigured outputs (#173088)\n\n## Summary\r\n\r\nCloses #173081 \r\n\r\nFixes output backfill for existing preconfigured outputs. \r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Nicolas Chaulet <[email protected]>","sha":"61b413ea05734b94c82cd07cef048f281deda3bd","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173088,"url":"https://github.com/elastic/kibana/pull/173088","mergeCommit":{"message":"[Fleet] Fix output backfill for preconfigured outputs (#173088)\n\n## Summary\r\n\r\nCloses #173081 \r\n\r\nFixes output backfill for existing preconfigured outputs. \r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Nicolas Chaulet <[email protected]>","sha":"61b413ea05734b94c82cd07cef048f281deda3bd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173088","number":173088,"mergeCommit":{"message":"[Fleet] Fix output backfill for preconfigured outputs (#173088)\n\n## Summary\r\n\r\nCloses #173081 \r\n\r\nFixes output backfill for existing preconfigured outputs. \r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Nicolas Chaulet <[email protected]>","sha":"61b413ea05734b94c82cd07cef048f281deda3bd"}}]}] BACKPORT--> Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #173081
Fixes output backfill for existing preconfigured outputs.
Checklist