Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading axios 1.6.x versions #174002

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

kc13greiner
Copy link
Contributor

@kc13greiner kc13greiner commented Dec 27, 2023

Summary

Upgrading patch version of axios 1.6.0 -> 1.6.3

@kc13greiner kc13greiner added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes v8.12.1 labels Dec 27, 2023
@kc13greiner
Copy link
Contributor Author

/ci

@kc13greiner kc13greiner marked this pull request as ready for review December 28, 2023 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we also update package.json with this new axios version (optional) and backport the change to 7.17?

@kc13greiner kc13greiner added the backport:all-open Backport to all branches that could still receive a release label Dec 28, 2023
@kc13greiner
Copy link
Contributor Author

/ci

@kc13greiner
Copy link
Contributor Author

@azasypkin definitely! Fixed in latest commit and added backport label

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / serverless search UI connectors create and configure connector edit name

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1209 1210 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.5KB 1013.7KB +200.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kc13greiner kc13greiner merged commit 079db3e into elastic:main Dec 28, 2023
37 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 28, 2023
## Summary

Upgrading patch version of `axios` 1.6.0 -> 1.6.3

(cherry picked from commit 079db3e)
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 28, 2023

Some backports had to be manually created

Status Branch Result
7.17
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 174002

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 28, 2023
# Backport

This will backport the following commits from `main` to `8.12`:
- [Upgrading axios 1.6.x versions
(#174002)](#174002)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Kurt","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-28T17:15:24Z","message":"Upgrading
axios 1.6.x versions (#174002)\n\n## Summary\r\n\r\nUpgrading patch
version of `axios` 1.6.0 ->
1.6.3","sha":"079db3e7ebcbed934c39d0efe67821317fe9eaec","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport:all-open","v8.12.1","v8.13.0"],"title":"Upgrading
axios 1.6.x
versions","number":174002,"url":"https://github.com/elastic/kibana/pull/174002","mergeCommit":{"message":"Upgrading
axios 1.6.x versions (#174002)\n\n## Summary\r\n\r\nUpgrading patch
version of `axios` 1.6.0 ->
1.6.3","sha":"079db3e7ebcbed934c39d0efe67821317fe9eaec"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174002","number":174002,"mergeCommit":{"message":"Upgrading
axios 1.6.x versions (#174002)\n\n## Summary\r\n\r\nUpgrading patch
version of `axios` 1.6.0 ->
1.6.3","sha":"079db3e7ebcbed934c39d0efe67821317fe9eaec"}}]}] BACKPORT-->

Co-authored-by: Kurt <[email protected]>
kc13greiner added a commit that referenced this pull request Dec 30, 2023
## Summary

Manual backport to 7.17 of axios upgrade 1.6.0 to 1.6.3

See #174002

---------

Co-authored-by: kibanamachine <[email protected]>
@kc13greiner kc13greiner deleted the feature/upgrade_axios_1.6.x branch January 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.12.0 v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants