Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncheck "Exclude matches from previous runs" by default #174019

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Uncheck "Exclude matches from previous runs" by default #174019

merged 2 commits into from
Dec 28, 2023

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Dec 28, 2023 •
edited
Loading

Resolves: #171790

Sets default value of the "Exclude matches from previous runs" checkbox' on Es Query rule type unchecked.

@ersin-erdal ersin-erdal added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0 labels Dec 28, 2023
@ersin-erdal ersin-erdal self-assigned this Dec 28, 2023
@ersin-erdal ersin-erdal force-pushed the 171790-exclude-metches branch from 6109eb9 to 119aeb7 Compare December 28, 2023 14:06
@ersin-erdal ersin-erdal marked this pull request as ready for review December 28, 2023 14:06
@ersin-erdal ersin-erdal requested a review from a team as a code owner December 28, 2023 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #185131 succeeded 6109eb9004be1d1097b29f144fe9de1c06691552

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ersin-erdal

ymao1
ymao1 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified existing rules keep their checked/unchecked status and new rules start out unchecked.

@ersin-erdal ersin-erdal merged commit 9ca9f73 into elastic:main Dec 28, 2023
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 28, 2023
@ersin-erdal ersin-erdal deleted the 171790-exclude-metches branch December 28, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees

@ersin-erdal ersin-erdal

Labels
backport:skip This commit does not require backporting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncheck "Exclude matches from previous runs" by default
5 participants
@ersin-erdal @elasticmachine @kibana-ci @ymao1 @kibanamachine