[Discover] Improve histogram functional tests #174038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
|
/ci |
|
/ci |
kertal
commented
Dec 28, 2023
Comment on lines
-73
to
-74
| await PageObjects.timePicker.setDefaultAbsoluteRange(); | ||
| await PageObjects.discover.waitUntilSearchingHasFinished(); |
There was a problem hiding this comment.
there's an occasional error that setting the timerange here again leads to a double submit. then the test is failing:
debg Find.allByCssSelector('.echChart') with timeout=10000
[00:04:39] │ debg renderings before brushing - actual: 2 expected: 1
[00:04:39] │ debg Find.allByCssSelector('.echChart') with timeout=10000
[00:04:39] │ debg renderings before brushing - actual: 2 expected: 1
Since there's no reason the set the time range, just submitting the query should be sufficient for re-rendering the histogram
kertal
commented
Dec 28, 2023
| @@ -43,6 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| ); | |||
| await security.testUser.setRoles(['kibana_admin', 'long_window_logstash']); | |||
| await kibanaServer.uiSettings.replace(defaultSettings); | |||
| await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings(); | |||
There was a problem hiding this comment.
Making the test a bit faster, since setting a different default time range in AdvancedSettings is faster than having to do so in UI
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
mattkime
approved these changes
Dec 28, 2023
kertal
added
the
backport:prev-minor
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 29, 2023
Improving Discover histogram tests to fix occasional flakiness due to a redundant time range UI interaction (cherry picked from commit 3c0a48c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 29, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Discover] Improve histogram functional tests (#174038)](#174038) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-29T18:08:11Z","message":"[Discover] Improve histogram functional tests (#174038)\n\nImproving Discover histogram tests to fix occasional flakiness due to a redundant time range UI interaction","sha":"3c0a48c86f927fb4998b734b7134203b8fd93090","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.13.0"],"title":"[Discover] Improve histogram functional tests","number":174038,"url":"https://github.com/elastic/kibana/pull/174038","mergeCommit":{"message":"[Discover] Improve histogram functional tests (#174038)\n\nImproving Discover histogram tests to fix occasional flakiness due to a redundant time range UI interaction","sha":"3c0a48c86f927fb4998b734b7134203b8fd93090"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174038","number":174038,"mergeCommit":{"message":"[Discover] Improve histogram functional tests (#174038)\n\nImproving Discover histogram tests to fix occasional flakiness due to a redundant time range UI interaction","sha":"3c0a48c86f927fb4998b734b7134203b8fd93090"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improving Discover histogram tests to fix occasional flakiness due to a redundant time range UI interaction
Fixes #170091
Fixes #173904
Flaky test runner
50x (stateful worked, serverless failed) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4703
50x (all tests serverless worked) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4705
Checklist