Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix requiredBundles for kibanaReact and kibanaUtils #174040

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Dec 28, 2023

As titled. kibanaUtils has an unused API and kibanaReact has no plugins. They should be requiredBundles in all instances.

In addition, when starting, Kibana detected plugins that weren't using the bundles at all. Those have been removed.

@clintandrewhall clintandrewhall added review chore loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.13.0 labels Dec 28, 2023
@clintandrewhall clintandrewhall requested a review from a team as a code owner December 28, 2023 19:10
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Changes LGTM, did not test locally!

Non blocker: I saw a few example plugins that also need these values updated:

./x-pack/examples/alerting_example/kibana.jsonc
./x-pack/examples/triggers_actions_ui_example/kibana.jsonc
./x-pack/examples/reporting_example/kibana.jsonc
./x-pack/examples/testing_embedded_lens/kibana.jsonc
./x-pack/examples/screenshotting_example/kibana.jsonc
./x-pack/examples/gen_ai_streaming_response_example/kibana.jsonc
./x-pack/examples/third_party_maps_source_example/kibana.jsonc

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Detection Engine - Security Solution Cypress Tests #4 / Timeline scope Alerts checkbox "before each" hook for "shows alerts badge when index patterns change and removes when reset" "before each" hook for "shows alerts badge when index patterns change and removes when reset"
  • [job] [logs] Detection Engine - Security Solution Cypress Tests #4 / Timeline scope Modified badge Selecting new data view does not add a modified badge Selecting new data view does not add a modified badge

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants