Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] remove .map from bundle_filepath value #174834

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

devcorpio
Copy link
Contributor

@devcorpio devcorpio commented Jan 15, 2024

Part of elastic/observability-docs#3354 (comment)

Summary

bundle_filepath should not contain .map.

@devcorpio devcorpio added release_note:skip Skip the PR/issue when compiling release notes v8.13.0 labels Jan 15, 2024
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@devcorpio devcorpio requested review from bmorelli25 and colleenmcginnis and removed request for bmorelli25 January 15, 2024 12:06
@devcorpio devcorpio added backport backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 15, 2024
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@devcorpio devcorpio merged commit 128506c into elastic:main Jan 16, 2024
18 checks passed
@devcorpio devcorpio deleted the update-sourcemap-docs branch January 16, 2024 16:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 16, 2024
Part of
elastic/observability-docs#3354 (comment)

## Summary

`bundle_filepath` should not contain `.map`.

(cherry picked from commit 128506c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 16, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Docs] remove .map from bundle_filepath value
(#174834)](#174834)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alberto Delgado
Roda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-16T16:59:23Z","message":"[Docs]
remove .map from bundle_filepath value (#174834)\n\nPart
of\r\nhttps://github.com/elastic/observability-docs/issues/3354#issuecomment-1849730927\r\n\r\n##
Summary\r\n\r\n`bundle_filepath` should not contain
`.map`.","sha":"128506c65291562af3ff71a515333af63a05e70a","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.13.0"],"title":"[Docs]
remove .map from bundle_filepath
value","number":174834,"url":"https://github.com/elastic/kibana/pull/174834","mergeCommit":{"message":"[Docs]
remove .map from bundle_filepath value (#174834)\n\nPart
of\r\nhttps://github.com/elastic/observability-docs/issues/3354#issuecomment-1849730927\r\n\r\n##
Summary\r\n\r\n`bundle_filepath` should not contain
`.map`.","sha":"128506c65291562af3ff71a515333af63a05e70a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174834","number":174834,"mergeCommit":{"message":"[Docs]
remove .map from bundle_filepath value (#174834)\n\nPart
of\r\nhttps://github.com/elastic/observability-docs/issues/3354#issuecomment-1849730927\r\n\r\n##
Summary\r\n\r\n`bundle_filepath` should not contain
`.map`.","sha":"128506c65291562af3ff71a515333af63a05e70a"}}]}]
BACKPORT-->

Co-authored-by: Alberto Delgado Roda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants