Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip edit data view test #176134

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Feb 2, 2024

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 2, 2024
@jughosta jughosta self-assigned this Feb 2, 2024
@jughosta jughosta marked this pull request as ready for review February 2, 2024 12:38
@jughosta jughosta requested a review from a team as a code owner February 2, 2024 12:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@jughosta jughosta merged commit f019b53 into elastic:main Feb 6, 2024
18 checks passed
@jughosta jughosta deleted the 174066-ft-edit-data-view branch February 6, 2024 08:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 6, 2024
- Closes elastic#174066

## Summary

50x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit f019b53)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 6, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Discover] Unskip edit data view test
(#176134)](#176134)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-06T08:07:34Z","message":"[Discover]
Unskip edit data view test (#176134)\n\n- Closes
https://github.com/elastic/kibana/issues/174066\r\n\r\n##
Summary\r\n\r\n50x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"f019b531a020c934ad67a4cd997b9a4508cbde49","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.13.0"],"title":"[Discover]
Unskip edit data view
test","number":176134,"url":"https://github.com/elastic/kibana/pull/176134","mergeCommit":{"message":"[Discover]
Unskip edit data view test (#176134)\n\n- Closes
https://github.com/elastic/kibana/issues/174066\r\n\r\n##
Summary\r\n\r\n50x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"f019b531a020c934ad67a4cd997b9a4508cbde49"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176134","number":176134,"mergeCommit":{"message":"[Discover]
Unskip edit data view test (#176134)\n\n- Closes
https://github.com/elastic/kibana/issues/174066\r\n\r\n##
Summary\r\n\r\n50x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"f019b531a020c934ad67a4cd997b9a4508cbde49"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
- Closes elastic#174066

## Summary

50x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
- Closes elastic#174066

## Summary

50x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
- Closes elastic#174066

## Summary

50x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.1 v8.13.0
Projects
None yet
5 participants