Make in-product APM alerting links smart (stateful vs serverless) #176252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
bmorelli25
changed the title
bmorelli25
added
release_note:skip
dedemorton
approved these changes
Mar 18, 2024
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@bmorelli25 I pushed a change to your PR, I don't know why but an e2e broke. |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 20, 2024
…astic#176252) ## Summary This is a part of elastic/observability-docs#3622. Before this PR, all four in-product APM alerting documentation links pointed to https://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR updates our in-product links to point to either our Serverless or Stateful documentation, depending on the product type. Closes elastic/observability-docs#3586. --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Caue Marcondes <[email protected]> (cherry picked from commit 62aa327)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 20, 2024
…ss) (#176252) (#179093) # Backport This will backport the following commits from `main` to `8.13`: - [Make in-product APM alerting links smart (stateful vs serverless) (#176252)](#176252) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brandon Morelli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-20T18:43:41Z","message":"Make in-product APM alerting links smart (stateful vs serverless) (#176252)\n\n## Summary\r\n\r\nThis is a part of\r\nhttps://github.com/elastic/observability-docs/issues/3622.\r\n\r\nBefore this PR, all four in-product APM alerting documentation links\r\npointed to\r\nhttps://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR\r\nupdates our in-product links to point to either our Serverless or\r\nStateful documentation, depending on the product type.\r\n\r\nCloses https://github.com/elastic/observability-docs/issues/3586.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Caue Marcondes <[email protected]>","sha":"62aa3279dfdfb12112827826b6ff2d76b50fbe96","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","v8.14.0","v8.13.1"],"title":"Make in-product APM alerting links smart (stateful vs serverless)","number":176252,"url":"https://github.com/elastic/kibana/pull/176252","mergeCommit":{"message":"Make in-product APM alerting links smart (stateful vs serverless) (#176252)\n\n## Summary\r\n\r\nThis is a part of\r\nhttps://github.com/elastic/observability-docs/issues/3622.\r\n\r\nBefore this PR, all four in-product APM alerting documentation links\r\npointed to\r\nhttps://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR\r\nupdates our in-product links to point to either our Serverless or\r\nStateful documentation, depending on the product type.\r\n\r\nCloses https://github.com/elastic/observability-docs/issues/3586.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Caue Marcondes <[email protected]>","sha":"62aa3279dfdfb12112827826b6ff2d76b50fbe96"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176252","number":176252,"mergeCommit":{"message":"Make in-product APM alerting links smart (stateful vs serverless) (#176252)\n\n## Summary\r\n\r\nThis is a part of\r\nhttps://github.com/elastic/observability-docs/issues/3622.\r\n\r\nBefore this PR, all four in-product APM alerting documentation links\r\npointed to\r\nhttps://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR\r\nupdates our in-product links to point to either our Serverless or\r\nStateful documentation, depending on the product type.\r\n\r\nCloses https://github.com/elastic/observability-docs/issues/3586.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Caue Marcondes <[email protected]>","sha":"62aa3279dfdfb12112827826b6ff2d76b50fbe96"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a part of elastic/observability-docs#3622.
Before this PR, all four in-product APM alerting documentation links pointed to https://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR updates our in-product links to point to either our Serverless or Stateful documentation, depending on the product type.
Closes elastic/observability-docs#3586.