-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] provide the ability to update/modify the User Messages #184985
[Lens] provide the ability to update/modify the User Messages #184985
Conversation
Thanks @markov00! @crespocarlos - are you able to check this over and confirm which requirements it will allow you to meet in the following issue? e.g. would it allow you to meet the designs Karolina shared? |
The changes allow us to get close to this version But it won't fully match.
@markov00 correct me if I'm wrong. |
We can probably find a generic icon that works in your case to put here as
correct. This is how every messages are displayed. We can probably force it a bit to make render it completely from your modified message, but I'm wondering if we are gaining benefit from that. If we can provide a way to change the icon, I believe that we can deviate a bit from the proposed style without UX issues, wdyt? |
@crespocarlos do you also need to know the name for each failing field or just catching this error is enough? |
@markov00 , catching this error is enough from now. @roshan-elastic do you think showing the missing fields adds any value for users? |
Thanks @crespocarlos for jumping on this! (and @markov00)
I'm not to worried about the perfect design and try and make UI handling very specific to us - I see the advantages of having the UX managed centrally as long as we have enough configurability. Do you know what level of flexibility it gives us?
If we wanted to show the missing fields in the box, could we do this in the error message? Also, would we have control to refer to a field in different |
@roshan-elastic We can provide a way to configure your own icon, but other then that you have complete freedom on how to render that popover panel.
Totally doable because you have complete freedom there |
Cool @markov00. I think it would make sense for us to leverage the icons you set based on the level (e.g. info, warn etc) but if we had the flexibility to use our own icon if we have to - that'd be great. Would that be part of this PR or would you need to update? |
Closing this PR in favor of this #189099 |
Summary
This PR provides an example of how an external Lens consumer can intercept and modify the UserMessages Lens shows when something in the visualization/data/configuration is wrong.
The Code also brings in a simple example of intercept and change how the field_not_found message will appear in the O11y solution infra/host page.
Before
After
fix #151526