Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples of client-side changes to consume getCurrentUser from core.security #186859

Conversation

tsullivan
Copy link
Member

Summary

Follows #186856

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@tsullivan tsullivan changed the title Security in core/authc get current user examples Examples of client-side changes to consume getCurrentUser from core.security Jun 24, 2024
@tsullivan
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 759.8KB 759.7KB -100.0B
imageEmbeddable 66.9KB 66.9KB -4.0B
maps 3.0MB 3.0MB -30.0B
total -134.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
imageEmbeddable 5.7KB 5.7KB -49.0B
maps 54.5KB 54.5KB -55.0B
total -104.0B
Unknown metric groups

References to deprecated APIs

id before after diff
dataVisualizer 13 9 -4
imageEmbeddable 2 1 -1
maps 31 30 -1
total -6

Unreferenced deprecated APIs

id before after diff
security 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

Closed in favor of:
#186915
#186917
#186918

@tsullivan tsullivan closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants